From: Dan Carpenter <error27@gmail.com>
To: Adith-Joshua <adithalex29@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, straube.linux@gmail.com
Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants
Date: Sat, 11 Apr 2026 11:07:31 +0300 [thread overview]
Message-ID: <adoBQ8skQ7aRXKNr@stanley.mountain> (raw)
In-Reply-To: <20260411052817.354594-1-adithalex29@gmail.com>
On Sat, Apr 11, 2026 at 10:58:17AM +0530, Adith-Joshua wrote:
> Replace hardcoded magic numbers in rtl8723b_InitBeaconParameters()
> with descriptive macros to improve readability and maintainability.
>
> No functional changes.
>
> Signed-off-by: Adith-Joshua <adithalex29@gmail.com>
> ---
Where did you find these numbers? Presumably there is a spec
somewhere? What does BCNTCFG_CW mean? This really looks like an AI
patch...
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-11 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 5:28 [PATCH] staging: rtl8723bs: replace magic numbers with named constants Adith-Joshua
2026-04-11 8:07 ` Dan Carpenter [this message]
2026-04-11 17:20 ` Luka Gejak
[not found] ` <CAFvcH2CjS=HMxt_Dd04eMAELQtxdB5LYmLa_1TLnJeEuKvR6=Q@mail.gmail.com>
2026-04-12 12:57 ` Dan Carpenter
[not found] ` <CAFvcH2DQJtB6B9L+SMgg_aPXGe96hw2i6+C1N0uhapHvJQHd2w@mail.gmail.com>
2026-04-13 5:41 ` Dan Carpenter
2026-04-11 17:15 ` Luka Gejak
-- strict thread matches above, loose matches on Subject: below --
2026-06-03 14:31 Jad Keskes
2026-06-04 14:31 ` Dan Carpenter
2026-06-04 14:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adoBQ8skQ7aRXKNr@stanley.mountain \
--to=error27@gmail.com \
--cc=adithalex29@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.