From: Dan Carpenter <error27@gmail.com>
To: Michael Ugrin <mugrinphoto@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
sakari.ailus@linux.intel.com, andy@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: media: atomisp: fix indentation to use tabs instead of spaces
Date: Sat, 11 Apr 2026 13:51:35 +0300 [thread overview]
Message-ID: <adont11Sr92pi0_N@stanley.mountain> (raw)
In-Reply-To: <20260411005512.46142-1-mugrinphoto@gmail.com>
On Fri, Apr 10, 2026 at 05:55:12PM -0700, Michael Ugrin wrote:
> Fix whitespace issue where a continuation line used spaces
> instead of tabs for indentation.
>
> Signed-off-by: Michael Ugrin <mugrinphoto@gmail.com>
> ---
> .../staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
> index b411ca2f415e0..966d4efb200c5 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
> @@ -1257,7 +1257,7 @@ ia_css_debug_pipe_graph_dump_stage(
> p--;
> /* Last comma found, copy till that comma */
> strscpy(enable_info1, ei,
> - p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
> + p > sizeof(enable_info1) ? sizeof(enable_info1) : p);
Better to use:
strscpy(enable_info1, ei, umin(p, sizeof(enable_info1)));
Same for the other strscpy() calls as well.
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-11 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 0:55 [PATCH] staging: media: atomisp: fix indentation to use tabs instead of spaces Michael Ugrin
[not found] ` <69d9bb8e.050a0220.25af5d.8ac6@mx.google.com>
2026-04-11 3:26 ` Michael Ugrin
2026-04-11 10:51 ` Dan Carpenter [this message]
2026-04-11 14:42 ` [PATCH] " David Laight
2026-04-11 17:13 ` Michael Ugrin
2026-04-13 7:24 ` Andy Shevchenko
2026-04-11 17:34 ` [PATCH v2] staging: media: atomisp: use umin() for strscpy size arguments Michael Ugrin
2026-04-13 7:01 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adont11Sr92pi0_N@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mugrinphoto@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.