From: Petr Vandrovec <vandrove@vc.cvut.cz>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: [PATCH] matroxfb dies when you try to use secondary head in 2.5.x
Date: Sat, 8 Jun 2002 02:12:56 +0200 [thread overview]
Message-ID: <adrifq$tc7$2@main.gmane.org> (raw)
Hi Linus,
please apply this to 2.5.20. James introduced bad bug which
causes NULL pointer dereference as soon as you'll try to use
secondary head because of screen_base is not initialized
(it is initialized on wrong head).
Thanks,
Petr Vandrovec
vandrove@vc.cvut.cz
diff -urdN linux/drivers/video/matrox/matroxfb_crtc2.c linux/drivers/video/matrox/matroxfb_crtc2.c
--- linux/drivers/video/matrox/matroxfb_crtc2.c Mon Jun 3 01:44:45 2002
+++ linux/drivers/video/matrox/matroxfb_crtc2.c Fri Jun 7 23:03:07 2002
@@ -383,7 +383,7 @@
chgvar = 0;
p->var = *var;
/* cmap */
- ACCESS_FBINFO(fbcon.screen_base) = vaddr_va(m2info->video.vbase);
+ m2info->fbcon.screen_base = vaddr_va(m2info->video.vbase);
p->visual = visual;
p->ypanstep = 1;
p->ywrapstep = 0;
_______________________________________________________________
Don't miss the 2002 Sprint PCS Application Developer's Conference
August 25-28 in Las Vegas - http://devcon.sprintpcs.com/adp/index.cfm?source=osdntextlink
next reply other threads:[~2002-06-08 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-08 0:12 Petr Vandrovec [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-06-08 0:12 [PATCH] matroxfb dies when you try to use secondary head in 2.5.x Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='adrifq$tc7$2@main.gmane.org' \
--to=vandrove@vc.cvut.cz \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.