All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Nguyen Duc Thinh <ducthinh100812@gmail.com>
Cc: Luka Gejak <luka.gejak@linux.dev>,
	gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] staging: rtl8723bs: rename dot11AuthAlgrthm to fix CamelCase
Date: Mon, 13 Apr 2026 10:47:31 +0300	[thread overview]
Message-ID: <adyfk-47opra_5fZ@stanley.mountain> (raw)
In-Reply-To: <20260412130012.5832-3-ducthinh100812@gmail.com>

On Sun, Apr 12, 2026 at 08:00:12PM +0700, Nguyen Duc Thinh wrote:
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
> index 4b4012411011..3ca8c3640acc 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
> @@ -228,7 +228,7 @@ void expire_timeout_chk(struct adapter *padapter)
>  			}
>  
>  			if (psta->state & WIFI_SLEEP_STATE) {
> -				if (!(psta->state & WIFI_STA_ALIVE_CHK_STATE)) {
> +				if !(psta->state & WIFI_STA_ALIVE_CHK_STATE) {

You need to be a lot more careful.

regards,
dan carpenter


  parent reply	other threads:[~2026-04-13  7:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 13:00 [PATCH v3 1/2] staging: most: dim2: replace BUG_ON() in enqueue() Nguyen Duc Thinh
2026-04-12 13:00 ` [PATCH v3 1/2] staging: most: dim2: replace BUG_ON() in poison_channel() Nguyen Duc Thinh
2026-04-12 13:00 ` [PATCH v3 2/2] staging: rtl8723bs: rename dot11AuthAlgrthm to fix CamelCase Nguyen Duc Thinh
2026-04-12 14:37   ` David Laight
2026-04-13  7:47   ` Dan Carpenter [this message]
2026-04-12 18:52 ` [PATCH v3 1/2] staging: most: dim2: replace BUG_ON() in enqueue() Greg KH
2026-04-12 20:43   ` Luka Gejak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adyfk-47opra_5fZ@stanley.mountain \
    --to=error27@gmail.com \
    --cc=ducthinh100812@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=luka.gejak@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.