All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: tanguy.raufflet@savoirfairelinux.com
Cc: meta-virtualization@lists.yoctoproject.org,
	paul.leguendekerneizon@savoirfairelinux.com
Subject: Re: [meta-virtualization][PATCH] cockpit-machines: remove autotools inheritance
Date: Mon, 13 Apr 2026 14:06:29 +0000	[thread overview]
Message-ID: <adz4ZXvb7fIwcekj@gmail.com> (raw)
In-Reply-To: <20260413114700.74906-1-tanguy.raufflet@savoirfairelinux.com>

I had these recipes skipped in my upgrade paths, since I didn't have
meta-webserver in bblayers.

I've confirmed the breakage and merged both patches to master.

Bruce

In message: [meta-virtualization][PATCH] cockpit-machines: remove autotools inheritance
on 13/04/2026 Tanguy Raufflet via lists.yoctoproject.org wrote:

> The commit [1] from openembedded-core, removes the possibility to use
> autotools bbclass when the configure script is missing. Because the
> cockpit-machines release tarball always ships pre-built assets in dist/,
> there is no need to use autotools to build the package.
> 
> This commit fixes the following build error:
>     ERROR: cockpit-machines-346-r0 do_configure: no configure script
>     found at ./configure
> 
> [1]: autotools: require that a configure script exists
>     SHA: 6d327a39befae44a88a812bdf4acde800dcee57b
> 
> Signed-off-by: Tanguy Raufflet <tanguy.raufflet@savoirfairelinux.com>
> ---
>  .../cockpit-machines/cockpit-machines_346.bb   | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/recipes-extended/cockpit-machines/cockpit-machines_346.bb b/recipes-extended/cockpit-machines/cockpit-machines_346.bb
> index 8aaac4c5..d23c39b2 100644
> --- a/recipes-extended/cockpit-machines/cockpit-machines_346.bb
> +++ b/recipes-extended/cockpit-machines/cockpit-machines_346.bb
> @@ -15,7 +15,7 @@ SRC_URI[sha256sum] = "c9d80357da2bf3ecda9698f0dc6fcb46675b3b76da9150a22178071fe9
>  
>  S = "${UNPACKDIR}/${PN}"
>  
> -inherit autotools-brokensep features_check gettext
> +inherit features_check
>  
>  # systemd, which cockpit is dependent, is not compatible with musl lib
>  COMPATIBLE_HOST:libc-musl = "null"
> @@ -24,10 +24,20 @@ RDEPENDS:${PN} += "cockpit libvirt-dbus pciutils virt-manager-install"
>  
>  REQUIRED_DISTRO_FEATURES = "systemd pam"
>  
> -# Default installation path of cockpit-machines is /usr/local/
> +do_configure[noexec] = "1"
> +do_compile[noexec] = "1"
> +
> +do_install() {
> +    install -d ${D}${datadir}/cockpit/machines
> +    cp -r ${S}/dist/* ${D}${datadir}/cockpit/machines/
> +
> +    install -d ${D}${datadir}/metainfo
> +    install -m 0644 ${S}/org.cockpit_project.machines.metainfo.xml ${D}${datadir}/metainfo/
> +}
> +
>  FILES:${PN} = "\
> -    ${prefix}/local/ \
> -    ${datadir}/metainfo/org.cockpit-project.cockpit-machines.metainfo.xml \
> +    ${datadir}/cockpit/machines/ \
> +    ${datadir}/metainfo/org.cockpit_project.machines.metainfo.xml \
>  "
>  
>  SKIP_RECIPE[cockpit-machines] ?= "${@bb.utils.contains('BBFILE_COLLECTIONS', 'webserver', '', 'Depends on meta-webserver which is not included', d)}"
> -- 
> 2.53.0
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#9694): https://lists.yoctoproject.org/g/meta-virtualization/message/9694
> Mute This Topic: https://lists.yoctoproject.org/mt/118802978/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 



      reply	other threads:[~2026-04-13 14:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-13 11:47 [meta-virtualization][PATCH] cockpit-machines: remove autotools inheritance Tanguy Raufflet
2026-04-13 14:06 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adz4ZXvb7fIwcekj@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=paul.leguendekerneizon@savoirfairelinux.com \
    --cc=tanguy.raufflet@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.