All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Fernando Fernandez Mancera <fmancera@suse.de>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	phil@nwl.cc
Subject: Re: [PATCH 3/3 nf v4] netfilter: xtables: fix L4 header parsing for non-first fragments
Date: Mon, 27 Apr 2026 18:33:37 +0200	[thread overview]
Message-ID: <ae-P4Sbl-0vpFrUY@strlen.de> (raw)
In-Reply-To: <ae-MRZ47QurmXY7z@chamomile>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> -               if (!(pkt->flags & NFT_PKTINFO_L4PROTO))
> +               if (!(pkt->flags & NFT_PKTINFO_L4PROTO) || pkt->fragoff)
>                         return false;

What is NFT_PKTINFO_L4PROTO supposed to mean?
I thought it meant there is an l4 header but its set unconditionally
for ipv4.  Only the ipv6 handling makes sense to me.

  reply	other threads:[~2026-04-27 16:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 11:27 [PATCH 1/3 nf v4] netfilter: nf_socket: skip socket lookup for non-first fragments Fernando Fernandez Mancera
2026-04-27 11:27 ` [PATCH 2/3 nf v4] netfilter: nf_tables: skip L4 header parsing " Fernando Fernandez Mancera
2026-04-27 11:27 ` [PATCH 3/3 nf v4] netfilter: xtables: fix " Fernando Fernandez Mancera
2026-04-27 16:18   ` Pablo Neira Ayuso
2026-04-27 16:33     ` Florian Westphal [this message]
2026-04-27 17:23       ` Pablo Neira Ayuso
2026-04-27 20:00         ` Fernando Fernandez Mancera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae-P4Sbl-0vpFrUY@strlen.de \
    --to=fw@strlen.de \
    --cc=coreteam@netfilter.org \
    --cc=fmancera@suse.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.