From: Shivang Upadhyay <shivangu@linux.ibm.com>
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
adityag@linux.ibm.com, harshpb@linux.ibm.com, npiggin@gmail.com,
milesg@linux.ibm.com
Subject: Re: [PATCH 2/2] ppc/pnv: add test to verify external DTB is honored
Date: Tue, 23 Jun 2026 21:12:19 +0530 [thread overview]
Message-ID: <ae00a32e337f66bff2bdd5a9a983231f0ae09ce1.camel@linux.ibm.com> (raw)
In-Reply-To: <20260623122410.5fae6f07-db-amachhiw@linux.ibm.com>
On Tue, 2026-06-23 at 12:27 +0530, Amit Machhiwal wrote:
> The test addition looks fine, but the commit message body is missing.
> According to the official QEMU submission guidelines at:
>
>
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#write-a-meaningful-commit-message
>
> "Commit messages should be meaningful and should stand on their own
> as
> a historical record of why the changes you applied were necessary
> or
> useful."
>
> You may want to add a commit message body in the next version.
Sure Amit, Ill add the body.
~Shivang.
next prev parent reply other threads:[~2026-06-23 15:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 6:31 [PATCH 0/2] ppc/pnv: fixing external dtb Shivang Upadhyay
2026-06-23 6:31 ` [PATCH 1/2] ppc/pnv: avoid regenerating DTB if external DTB is present Shivang Upadhyay
2026-06-25 7:51 ` Aditya Gupta
2026-06-25 7:54 ` Shivang Upadhyay
2026-06-23 6:31 ` [PATCH 2/2] ppc/pnv: add test to verify external DTB is honored Shivang Upadhyay
2026-06-23 6:57 ` Amit Machhiwal
2026-06-23 15:42 ` Shivang Upadhyay [this message]
2026-06-25 7:02 ` Aditya Gupta
2026-06-25 7:30 ` Shivang Upadhyay
2026-06-26 11:22 ` [PATCH v2 0/2] ppc/pnv: fixing external dtb Shivang Upadhyay
2026-06-26 11:22 ` [PATCH v2 1/2] ppc/pnv: avoid regenerating DTB if external DTB is present Shivang Upadhyay
2026-06-29 11:41 ` Aditya Gupta
2026-06-26 11:22 ` [PATCH v2 2/2] ppc/pnv: add test to verify external DTB is honored Shivang Upadhyay
2026-06-29 11:53 ` Aditya Gupta
2026-06-30 9:37 ` Shivang Upadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae00a32e337f66bff2bdd5a9a983231f0ae09ce1.camel@linux.ibm.com \
--to=shivangu@linux.ibm.com \
--cc=adityag@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=milesg@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.