Re: [PATCH 5/6] arm64: dts: fsd: Add PPMU support for MFC block of FSD SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/07/2025 12:32, Vivek Yadav wrote:
> Add device tree node for PPMU instances in MFC block and
> enable the same for Tesla FSD platform.
> 
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> Signed-off-by: Vivek Yadav <vivek.2311@samsung.com>
> ---
>  arch/arm64/boot/dts/tesla/fsd-evb.dts |  8 ++++++++
>  arch/arm64/boot/dts/tesla/fsd.dtsi    | 20 ++++++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> index 8d7794642900..f543c7dad7cc 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> @@ -110,3 +110,11 @@ &serial_0 {
>  &ufs {
>  	status = "okay";
>  };
> +
> +&ppmu0_mfc {

Follow DTS coding style.

> +	status = "okay";
> +};
> +
> +&ppmu1_mfc {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index 690b4ed9c29b..7b6e7d81be10 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -970,6 +970,26 @@ timer@10040000 {
>  			clock-names = "fin_pll", "mct";
>  		};
>  
> +		ppmu0_mfc: ppmu@12840000 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


> +			compatible = "samsung,ppmu-v2";

See writing bindings, DTS coding style and all other documents there
explaining why this is wrong.


Best regards,
Krzysztof