All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Michal Hocko <mhocko@kernel.org>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	qing.huang@oracle.com, tariqt@mellanox.com,
	haakon.bugge@oracle.com, yanjun.zhu@oracle.com,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, gi-oh.kim@profitbricks.com
Subject: Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks
Date: Thu, 31 May 2018 04:35:31 -0400	[thread overview]
Message-ID: <ae114f01-4b09-bb1c-fb92-6152486a896f@gmail.com> (raw)
In-Reply-To: <20180531065405.GH15278@dhcp22.suse.cz>



On 05/31/2018 02:54 AM, Michal Hocko wrote:
> On Tue 29-05-18 23:49:59, Eric Dumazet wrote:
>>
>>
>> On 05/29/2018 11:44 PM, Eric Dumazet wrote:
>>
>>>
>>> And I will add this simple fix, this really should address your initial concern much better.
>>>
>>> @@ -99,6 +100,8 @@ static int mlx4_alloc_icm_pages(struct scatterlist *mem, int order,
>>>  {
>>>         struct page *page;
>>>  
>>> +       if (order)
>>> +               gfp_mask |= __GFP_NORETRY;
>>
>>     and also      gfp_mask &= ~__GFP_DIRECT_RECLAIM
> 
> JFTR the latter one makes __GFP_NORETRY pointless. Non sleeping allocations
> are not retrying.

Hi Michal

Since when this rule is applied ?

These GFP flags change all the time, I suggest mm experts to cleanup existing call sites ?

I merely copied/pasted from alloc_skb_with_frags() :/

Thanks !

  reply	other threads:[~2018-05-31  8:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 23:22 [PATCH V4] mlx4_core: allocate ICM memory in page size chunks Qing Huang
2018-05-24  7:23 ` Gi-Oh Kim
2018-05-24  9:45 ` Tariq Toukan
2018-05-25 14:23 ` David Miller
2018-05-30  3:34   ` Eric Dumazet
2018-05-30  3:44     ` Eric Dumazet
2018-05-30  3:49       ` Eric Dumazet
2018-05-30 17:39         ` Qing Huang
2018-05-31  6:54         ` Michal Hocko
2018-05-31  8:35           ` Eric Dumazet [this message]
2018-05-31  8:55             ` Michal Hocko
2018-05-31  9:10               ` Michal Hocko
2018-06-01  2:04                 ` Qing Huang
2018-06-01  7:31                   ` Michal Hocko
2018-06-01 22:05                     ` Qing Huang
2018-06-04  6:27                       ` Michal Hocko
2018-06-04 12:40                         ` Vlastimil Babka
2018-06-05 18:51                           ` Qing Huang
2018-06-04 13:11                 ` Michal Hocko
2018-06-04 13:22                   ` Eric Dumazet
2018-06-05  8:32                     ` Michal Hocko
2018-05-30 17:53     ` Qing Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae114f01-4b09-bb1c-fb92-6152486a896f@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gi-oh.kim@profitbricks.com \
    --cc=haakon.bugge@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=qing.huang@oracle.com \
    --cc=tariqt@mellanox.com \
    --cc=yanjun.zhu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.