From: Lukas Timmermann <linux@timmermann.space>
To: Sasha Levin <sashal@kernel.org>, Lee Jones <lee@kernel.org>
Cc: Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: as3668: Fix Kconfig symbol name mismatch in Makefile
Date: Sun, 26 Apr 2026 10:08:26 +0200 [thread overview]
Message-ID: <ae3FDpQF8rBmoiKn@archstation> (raw)
In-Reply-To: <20260426000322.55999-1-sashal@kernel.org>
On Sat, Apr 25, 2026 at 08:03:21PM -0400, Sasha Levin wrote:
> kconfiglint reports:
>
> X001: CONFIG_LEDS_AS3668 referenced in Makefile but not defined
> in any Kconfig
>
> The AS3668 LED driver was introduced in
> commit c7dd343a3756 ("leds:
> as3668: Driver for the ams Osram 4-channel i2c LED driver").
> That commit defined the Kconfig symbol as LEDS_OSRAM_AMS_AS3668 in
> drivers/leds/Kconfig but used the shorter name LEDS_AS3668 in the
> Makefile's obj-* line.
>
> Because the Makefile references CONFIG_LEDS_AS3668 which does not exist,
> the driver can never be built — the obj-* line always evaluates to
> obj- += leds-as3668.o (empty config), so the object file is never
> compiled regardless of what the user selects in menuconfig.
Thanks for pointing that out. Seems like I tested with an older .config
or something like that.
Acked-by: Lukas Timmermann <linux@timmermann.space>
>
> Fix the Makefile to reference the correct Kconfig symbol
> CONFIG_LEDS_OSRAM_AMS_AS3668, matching what is defined in
> drivers/leds/Kconfig.
>
> Assisted-by: Claude:claude-opus-4-6 kconfiglint
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> drivers/leds/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> index 8fdb45d5b4393..7db3768912ca5 100644
> --- a/drivers/leds/Makefile
> +++ b/drivers/leds/Makefile
> @@ -15,7 +15,7 @@ obj-$(CONFIG_LEDS_ADP5520) += leds-adp5520.o
> obj-$(CONFIG_LEDS_AN30259A) += leds-an30259a.o
> obj-$(CONFIG_LEDS_APU) += leds-apu.o
> obj-$(CONFIG_LEDS_ARIEL) += leds-ariel.o
> -obj-$(CONFIG_LEDS_AS3668) += leds-as3668.o
> +obj-$(CONFIG_LEDS_OSRAM_AMS_AS3668) += leds-as3668.o
> obj-$(CONFIG_LEDS_AW200XX) += leds-aw200xx.o
> obj-$(CONFIG_LEDS_AW2013) += leds-aw2013.o
> obj-$(CONFIG_LEDS_BCM6328) += leds-bcm6328.o
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-04-26 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 0:03 [PATCH] leds: as3668: Fix Kconfig symbol name mismatch in Makefile Sasha Levin
2026-04-26 8:08 ` Lukas Timmermann [this message]
2026-05-07 13:14 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae3FDpQF8rBmoiKn@archstation \
--to=linux@timmermann.space \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.