From: Thomas Huth <thuth@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>
Cc: qemu-devel@nongnu.org, alex.bennee@linaro.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v2] docs: build-system: rename "default-configs" to "configs"
Date: Thu, 1 Jun 2023 11:12:21 +0200 [thread overview]
Message-ID: <ae3fd7f8-863d-5a78-8483-0ccd2ffe511d@redhat.com> (raw)
In-Reply-To: <ZHhUBHCHnx+2fNG+@pinwheel>
On 01/06/2023 10.17, Kashyap Chamarthy wrote:
> On Wed, May 31, 2023 at 04:22:34PM +0200, Thomas Huth wrote:
>> On 23/05/2023 15.31, Kashyap Chamarthy wrote:
>>> Commit 812b31d3f9 (configs: rename default-configs to configs and
>>> reorganise, 2021-07-07) did the rename.
>>>
>>> Reflect that update also in the documentation.
>>>
>>> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
>>> ---
>>> docs/devel/build-system.rst | 12 +++++------
>>> docs/devel/kconfig.rst | 40 ++++++++++++++++++++-----------------
>>> 2 files changed, 28 insertions(+), 24 deletions(-)
>>>
>>> diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
>>> index 1894721743..20ebcc9ac6 100644
>>> --- a/docs/devel/build-system.rst
>>> +++ b/docs/devel/build-system.rst
>> ...
>>> @@ -457,7 +457,7 @@ Built by Meson:
>>> TARGET-NAME is again the name of a system or userspace emulator. The
>>> config-devices.mak file is automatically generated by make using the
>>> scripts/make_device_config.sh program, feeding it the
>>> - default-configs/$TARGET-NAME file as input.
>>> + configs/$TARGET-NAME file as input.
>>
>> This hunk does not apply anymore - but I think it can simply be dropped now.
>
> Just for my own clarity, which precise part do you suggest to be
> dropped?
The above line seems to be gone, so it does not need fixing anymore, I
think. You'll see it when you rebase your patch.
Thomas
prev parent reply other threads:[~2023-06-01 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 13:31 [PATCH v2] docs: build-system: rename "default-configs" to "configs" Kashyap Chamarthy
2023-05-23 13:45 ` Kashyap Chamarthy
2023-05-31 14:22 ` Thomas Huth
2023-06-01 8:17 ` Kashyap Chamarthy
2023-06-01 9:12 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae3fd7f8-863d-5a78-8483-0ccd2ffe511d@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=kchamart@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.