From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHv3 net-next 2/2] selftests: add a selftest for directed
 broadcast forwarding
Date: Tue, 24 Jul 2018 11:37:05 -0600
Message-ID: <ae804f04-2be2-e79d-5f43-033e275fbd66@gmail.com>
References: <cover.1532346504.git.lucien.xin@gmail.com>
 <8b30fcb80234d6d0f96e703487cf4a4195fc1c48.1532346504.git.lucien.xin@gmail.com>
 <a3c46ade85539e450f037e62984f750c7d56084d.1532346504.git.lucien.xin@gmail.com>
 <5af03df3-cad5-161e-31a8-3921fd64b98a@gmail.com>
 <CADvbK_dhnyZwqzff64ZQBggL8LcY__ot_h3Cj7Y-SOx1FxGbCw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: network dev <netdev@vger.kernel.org>, davem <davem@davemloft.net>,
        Davide Caratti <dcaratti@redhat.com>,
        Ido Schimmel <idosch@idosch.org>
To: Xin Long <lucien.xin@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg1-f180.google.com ([209.85.215.180]:42889 "EHLO
        mail-pg1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388401AbeGXSol (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 24 Jul 2018 14:44:41 -0400
Received: by mail-pg1-f180.google.com with SMTP id y4-v6so3376371pgp.9
        for <netdev@vger.kernel.org>; Tue, 24 Jul 2018 10:37:08 -0700 (PDT)
In-Reply-To: <CADvbK_dhnyZwqzff64ZQBggL8LcY__ot_h3Cj7Y-SOx1FxGbCw@mail.gmail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 7/24/18 11:24 AM, Xin Long wrote:
> On Mon, Jul 23, 2018 at 11:17 PM, David Ahern <dsahern@gmail.com> wrote:
>> On 7/23/18 5:51 AM, Xin Long wrote:
>>> +ping_ipv4()
>>> +{
>>> +     sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0
>>> +
>>> +     bc_forwarding_disable
>>> +     ping_test_from $h1 198.51.100.255 192.0.2.1
>>> +     ping_test_from $h1 198.51.200.255 192.0.2.1
>>> +     ping_test_from $h1 192.0.2.255 192.0.2.1
>>> +     ping_test_from $h1 255.255.255.255 192.0.2.1
>>> +
>>> +     ping_test_from $h2 192.0.2.255 198.51.100.1
>>> +     ping_test_from $h2 198.51.200.255 198.51.100.1
>>> +     ping_test_from $h2 198.51.100.255 198.51.100.1
>>> +     ping_test_from $h2 255.255.255.255 198.51.100.1
>>> +     bc_forwarding_restore
>>> +
>>> +     bc_forwarding_enable
>>> +     ping_test_from $h1 198.51.100.255 198.51.100.2
>>> +     ping_test_from $h1 198.51.200.255 198.51.200.2
>>> +     ping_test_from $h1 192.0.2.255 192.0.2.1 1
>>> +     ping_test_from $h1 255.255.255.255 192.0.2.1
>>> +
>>> +     ping_test_from $h2 192.0.2.255 192.0.2.2
>>> +     ping_test_from $h2 198.51.200.255 198.51.200.2
>>> +     ping_test_from $h2 198.51.100.255 198.51.100.1 1
>>> +     ping_test_from $h2 255.255.255.255 198.51.100.1
>>> +     bc_forwarding_restore
>>> +
>>> +     sysctl_restore net.ipv4.icmp_echo_ignore_broadcasts
>>
>> You need a better description for each test. This output:
>> TEST: ping_test_from                            [PASS]
>> TEST: ping_test_from                            [PASS]
>> TEST: ping_test_from                            [PASS]
>> TEST: ping_test_from                            [PASS]
>> ...
>>
>> does not help in understanding which cases are working and which are not.
> # ./router_broadcast.sh
> INFO: bc_forwarding disabled on r1=>
> INFO: h1 -> net2: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h1 -> net3: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h1 -> net1: reply from r1 (not dropping)
> TEST: ping_test_from                                                [PASS]
> INFO: h1 -> 255.255.255.255: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> net1: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> net3: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> net2: reply from r1 (not dropping)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> 255.255.255.255: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: bc_forwarding enabled on r1 =>
> INFO: h1 -> net2: reply from h2 (forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h1 -> net3: reply from h3 (forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h1 -> net1: no reply (dropping)
> TEST: ping_test_from                                                [PASS]
> INFO: h1 -> 255.255.255.255: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> net1: reply from h3 (forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> net3: reply from h1 (forwarding)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> net2: no reply (dropping)
> TEST: ping_test_from                                                [PASS]
> INFO: h2 -> 255.255.255.255: reply from r1 (not forwarding)
> TEST: ping_test_from                                                [PASS]
> 
> I hope this log looks good to you?
> 

The extra INFO is good, but the TEST line needs a better description.