From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cIt39-0001Sh-4j for ath10k@lists.infradead.org; Mon, 19 Dec 2016 08:12:00 +0000 MIME-Version: 1.0 Date: Mon, 19 Dec 2016 13:41:35 +0530 From: Tamizh chelvam Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX In-Reply-To: <1481881024.27953.14.camel@sipsolutions.net> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> <1481881024.27953.14.camel@sipsolutions.net> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Johannes Berg Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org SGkgSm9oYW5uZXMsCgpUaGFua3MgZm9yIHlvdXIgY29tbWVudHMuCgpPbiAyMDE2LTEyLTE2IDE1 OjA3LCBKb2hhbm5lcyBCZXJnIHdyb3RlOgo+PiA+ID4gaXMgaXQgZmluZSB0byBoYXZlIGFzIFdJ UEhZX0JUQ09FWF9CRV9QUkVGRVJSRUQgPwo+PiA+Cj4+ID4gSXQncyBub3QgcmVhbGx5IGNsZWFy IHRvIG1lIHdoYXQgeW91IGludGVuZCB0byBkbyB0aGlzIC0gaWYgaXQncwo+PiA+IHJlYWxseSBz dXBwb3J0IGZsYWdzIHRoZW4geW91IHJlYWxseSBzaG91bGQgbmFtZSB0aG9zZSBiZXR0ZXIuCj4+ ID4KPj4gCj4+IFRoaXMgaXMgc3VwcG9ydCBmbGFncyBhbmQgaXQgdXNlZCBieSB0aGUgZHJpdmVy IHRvIGludGltYXRlIGRyaXZlcsKgCj4+IHN1cHBvcnRlZCBmcmFtZSB0eXBlIGZvciB0aGUgQlRD T0VYIHRvIGNmZyBsaWtlCj4+ICJ3aXBoeV93b3dsYW5fc3VwcG9ydF9mbGFncyIgaW1wbGVtZW50 YXRpb24uIFBsZWFzZSBzdWdnZXN0IGlmIHRoaXMKPj4gaXMgb2sgPyBJIHdpbGwgYmUgdGhhbmtm dWwgaWYgeW91IGNhbiBzdWdnZXN0IGHCoCBiZXR0ZXIgb25lIGlmIHRoaXMKPj4gaXMgbm90IG9r ICJXSVBIWV9CVENPRVhfU1VQUE9SVFNfQkUiCj4gCj4gV2VsbCwgSSBzZWUgYSBmZXcgdGhpbmdz IGhlcmU6Cj4gCj4gMSkgZG9lcyBpdCBldmVuIG1ha2Ugc2Vuc2UgdG8gc3BsaXQgaXQgb3V0IHBl ciBBQz8gd291bGRuJ3QgaXQgYmUgd2VpcmQKPiBpZiB5b3Ugc3VwcG9ydGVkIHRoaXMgb25seSBm b3IgVk8gYW5kIEJLLCBhbmQgbm90IHRoZSBvdGhlcnMsIG9yCj4gc29tZXRoaW5nIGxpa2UgdGhh dD8KPiAKSXQgaGFzIHN1cHBvcnQgZm9yIEJFLCBWSSwgbWFuYWdlbWVudCBhbmQgYmVhY29uIGZy YW1lcyBhbHNvLgpPciBkbyB5b3UgbWVhbnQgdG8gc2F5IGxpa2Ugc3VwcG9ydCBvbmx5IGZvciBW TyBhbmQgQks/Cgo+IDIpIFdvdWxkbid0IGl0IG1ha2UgbW9yZSBzZW5zZSB0byBkZWZpbmUgdGhp cyBpbiBubDgwMjExIGFuZCBqdXN0IHBhc3MKPiB0aGUgYml0bWFwIHRocm91Z2ggdG8gdXNlcnNw YWNlPyBUaGF0IHdvdWxkIHNhdmUgcXVpdGUgYSBiaXQgb2YgbmV0bGluawo+IG1hbmdsaW5nIGNv bXBsZXhpdHkuCj4gClBsZWFzZSBsZXQgbWUga25vdyBpZiB0aGUgYmVsb3cgZGVzaWduL3Rob3Vn aHQgaXMgZmluZSB0byB5b3UuCgppdyBwaHlYIHNldCBidGNvZXhfcHJpb3JpdHkgPFt2aSwgdm8s IGJlLCBiaywgbWdtdCwgYmVhY29uXT4KCkJ5IHRoaXMgY29tbWFuZCB1c2VyIHNob3VsZCBnaXZl IG9uZSBvciBtb3JlIHRoYW4gb25lIGZyYW1lIHR5cGVzIGZvciAKdGhpcyBidGNvZXggcHJpb3Jp dHksCndlIHdpbGwgcGFyc2UgdGhhdCBpbiAiaXciIGFuZCBzZW5kIGFzIGEgc2luZ2xlIGJpdG1h cChsZXNzIHRoYW4gMHg2NCkgCnRvCnRoZSBkcml2ZXI/Cgo+IDMpIEkgdGhpbmsgdGhlIG5hbWlu ZyBpcyBjb25mdXNpbmcgLSAiV0lQSFlfQlRDT0VYX1NVUFBPUlRTX0JFX1BSRUYiIG9yCj4gc28g bWlnaHQgYmUgbW9yZSBhcHByb3ByaWF0ZT8KPiAKSWYgdGhlIGFib3ZlIHN1Z2dlc3Rpb24gaXMg ZmluZSwgd2UgbWF5IG5vdCBuZWVkIHRoZXNlIGZsYWdzLgoKPj4gRG8geW91IG1lYW4gdG8gc2F5 LCBzZW5kaW5nIGEgdmFsdWUgZnJvbSB1c2VyIHNwYWNlIGFuZCBwYXJzZSB0aGF0Cj4+IGluwqAg dGhlIGRyaXZlcj8KPiAKPiBJIHdhcyBtb3JlIHRoaW5raW5nIG9mIHRoZSBjYXBhYmlsaXR5IGFk dmVydGlzZW1lbnQsIGJ1dCB5ZWFoLCBib3RoCj4gd2F5cyBzZWVtcyByZWFzb25hYmxlLgo+IApP a2F5LgoKVGhhbmtzLApUYW1pemguCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:51882 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752082AbcLSILg (ORCPT ); Mon, 19 Dec 2016 03:11:36 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Mon, 19 Dec 2016 13:41:35 +0530 From: Tamizh chelvam To: Johannes Berg Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX In-Reply-To: <1481881024.27953.14.camel@sipsolutions.net> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> <1481881024.27953.14.camel@sipsolutions.net> Message-ID: (sfid-20161219_091252_937848_9991609E) Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Johannes, Thanks for your comments. On 2016-12-16 15:07, Johannes Berg wrote: >> > > is it fine to have as WIPHY_BTCOEX_BE_PREFERRED ? >> > >> > It's not really clear to me what you intend to do this - if it's >> > really support flags then you really should name those better. >> > >> >> This is support flags and it used by the driver to intimate driver  >> supported frame type for the BTCOEX to cfg like >> "wiphy_wowlan_support_flags" implementation. Please suggest if this >> is ok ? I will be thankful if you can suggest a  better one if this >> is not ok "WIPHY_BTCOEX_SUPPORTS_BE" > > Well, I see a few things here: > > 1) does it even make sense to split it out per AC? wouldn't it be weird > if you supported this only for VO and BK, and not the others, or > something like that? > It has support for BE, VI, management and beacon frames also. Or do you meant to say like support only for VO and BK? > 2) Wouldn't it make more sense to define this in nl80211 and just pass > the bitmap through to userspace? That would save quite a bit of netlink > mangling complexity. > Please let me know if the below design/thought is fine to you. iw phyX set btcoex_priority <[vi, vo, be, bk, mgmt, beacon]> By this command user should give one or more than one frame types for this btcoex priority, we will parse that in "iw" and send as a single bitmap(less than 0x64) to the driver? > 3) I think the naming is confusing - "WIPHY_BTCOEX_SUPPORTS_BE_PREF" or > so might be more appropriate? > If the above suggestion is fine, we may not need these flags. >> Do you mean to say, sending a value from user space and parse that >> in  the driver? > > I was more thinking of the capability advertisement, but yeah, both > ways seems reasonable. > Okay. Thanks, Tamizh.