All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sheetal Sahasrabudhe" <sheetals@codeaurora.org>
To: Bryan Huntsman <bryanh@codeaurora.org>
Cc: Sheetal Sahasrabudhe <sheetals@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org, will.deacon@arm.com,
	jamie.iles@picochip.com, jean.pihet@newoldbits.com,
	robert.richter@amd.com, dwalker@fifo99.com,
	davidb@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
Date: Sat, 5 Mar 2011 13:40:07 -0800 (PST)	[thread overview]
Message-ID: <ae824b511bff00411fa33086cb529c32.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <4D716AD5.1070403@codeaurora.org>

Hi Bryan,

> Some minor comments from a quick review:
> - you're using multi-line commenting style for single line comments
> - see Documentation/CodingStyle, Chapter 8, for preferred multi-line
> commenting style
I will fix the commenting style wherever needed.

> - 'mv perf_event_qc.c perf_event_msm.c'?
That's fine with me.

Thanks,
Sheetal

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.




WARNING: multiple messages have this Message-ID (diff)
From: sheetals@codeaurora.org (Sheetal Sahasrabudhe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile
Date: Sat, 5 Mar 2011 13:40:07 -0800 (PST)	[thread overview]
Message-ID: <ae824b511bff00411fa33086cb529c32.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <4D716AD5.1070403@codeaurora.org>

Hi Bryan,

> Some minor comments from a quick review:
> - you're using multi-line commenting style for single line comments
> - see Documentation/CodingStyle, Chapter 8, for preferred multi-line
> commenting style
I will fix the commenting style wherever needed.

> - 'mv perf_event_qc.c perf_event_msm.c'?
That's fine with me.

Thanks,
Sheetal

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: "Sheetal Sahasrabudhe" <sheetals@codeaurora.org>
To: "Bryan Huntsman" <bryanh@codeaurora.org>
Cc: "Sheetal Sahasrabudhe" <sheetals@codeaurora.org>,
	linux-arm-kernel@lists.infradead.org, will.deacon@arm.com,
	jamie.iles@picochip.com, jean.pihet@newoldbits.com,
	robert.richter@amd.com, dwalker@fifo99.com,
	davidb@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and  Oprofile
Date: Sat, 5 Mar 2011 13:40:07 -0800 (PST)	[thread overview]
Message-ID: <ae824b511bff00411fa33086cb529c32.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <4D716AD5.1070403@codeaurora.org>

Hi Bryan,

> Some minor comments from a quick review:
> - you're using multi-line commenting style for single line comments
> - see Documentation/CodingStyle, Chapter 8, for preferred multi-line
> commenting style
I will fix the commenting style wherever needed.

> - 'mv perf_event_qc.c perf_event_msm.c'?
That's fine with me.

Thanks,
Sheetal

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.




  reply	other threads:[~2011-03-05 21:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 22:09 [PATCH 0/3] ARM: Add Scorpion/ScorpionMP support to perf and Oprofile Sheetal Sahasrabudhe
2011-03-04 22:09 ` Sheetal Sahasrabudhe
2011-03-04 22:42 ` Bryan Huntsman
2011-03-04 22:42   ` Bryan Huntsman
2011-03-05 21:40   ` Sheetal Sahasrabudhe [this message]
2011-03-05 21:40     ` Sheetal Sahasrabudhe
2011-03-05 21:40     ` Sheetal Sahasrabudhe
2011-03-07 10:06 ` Jean Pihet
2011-03-07 10:06   ` Jean Pihet
2011-03-07 10:06   ` Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae824b511bff00411fa33086cb529c32.squirrel@www.codeaurora.org \
    --to=sheetals@codeaurora.org \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@fifo99.com \
    --cc=jamie.iles@picochip.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.richter@amd.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.