From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Jindřich Makovička" <makovick@gmail.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>
Subject: Re: [PATCH v3 0/2] Fix and re-enable GTK clipboard
Date: Mon, 27 Apr 2026 09:56:20 +0100 [thread overview]
Message-ID: <ae8ktG9zNOKXHgSu@redhat.com> (raw)
In-Reply-To: <20260426-gtk-clipboard-v3-0-09555aaeda34@gmail.com>
On Sun, Apr 26, 2026 at 09:52:32AM +0200, Jindřich Makovička wrote:
> The following patches change blocking clipboard retrieval function
> calls in gtk-clipboard.c to non-blocking variants using callbacks to
> avoid UI lockup. It is a follow-up to the patch proposed in the GitLab
> issue
>
> https://gitlab.com/qemu-project/qemu/-/work_items/1150
>
> This version adds a similar change to gd_clipboard_request that also
> uses the blocking clipboard API.
>
> The second patch removes the gtk-clipboard flag, keeping the GTK
> clipboard always enabled.
I notice that the current code in git does not provide any command line
option to turn on/off the GTK clipboard sync. Considering that VMs are
often used for untrusted workloads, or workloads that are less trusted
then the host OS, I would consider this GTK impl to be a security flaw
in QEMU if re-enabled as-is.
IMHO, before we remove the ifdefs in the code, the "DisplayGTK" struct
needs to gain settings to control the clipboard synchronization, and it
should default to disabled.
next prev parent reply other threads:[~2026-04-27 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 7:52 [PATCH v3 0/2] Fix and re-enable GTK clipboard Jindřich Makovička
2026-04-26 7:52 ` [PATCH v3 1/2] ui/gtk: Use non-blocking clipboard retrieval Jindřich Makovička
2026-04-27 8:47 ` Marc-André Lureau
2026-04-27 19:40 ` Jindrich Makovicka
2026-04-27 8:52 ` Marc-André Lureau
2026-04-27 19:26 ` Jindrich Makovicka
2026-04-28 5:59 ` Jindrich Makovicka
2026-04-26 7:52 ` [PATCH v3 2/2] ui/gtk: Keep GTK clipboard enabled Jindřich Makovička
2026-04-27 8:56 ` Daniel P. Berrangé [this message]
2026-04-27 20:10 ` [PATCH v3 0/2] Fix and re-enable GTK clipboard Jindrich Makovicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae8ktG9zNOKXHgSu@redhat.com \
--to=berrange@redhat.com \
--cc=makovick@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.