All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [RESEND PATCH 7/7] drm/dp: Add target_rr_divider field in AS SDP logging
Date: Mon, 27 Apr 2026 15:58:59 +0300	[thread overview]
Message-ID: <ae9dk1xLGfCF-ZH3@intel.com> (raw)
In-Reply-To: <20260424093424.3060805-8-ankit.k.nautiyal@intel.com>

On Fri, Apr 24, 2026 at 03:04:24PM +0530, Ankit Nautiyal wrote:
> The field target_rr_divider is missing from the AS SDP logging.
> Add it and print the divider value (1.001 or 1.000) as per the DP 2.1 spec.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index 102328d9022d..c8421099a3ac 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -3537,6 +3537,8 @@ void drm_dp_as_sdp_log(struct drm_printer *p, const struct drm_dp_as_sdp *as_sdp
>  		   dp_sdp_type_get_name(as_sdp->sdp_type), as_sdp->revision, as_sdp->length);
>  	drm_printf(p, "    vtotal: %d\n", as_sdp->vtotal);
>  	drm_printf(p, "    target_rr: %d\n", as_sdp->target_rr);
> +	drm_printf(p, "    target_rr_divider: %s\n",
> +		   as_sdp->target_rr_divider ? "1.001" : "1.000");
>  	drm_printf(p, "    duration_incr_ms: %d\n", as_sdp->duration_incr_ms);
>  	drm_printf(p, "    duration_decr_ms: %d\n", as_sdp->duration_decr_ms);
>  	drm_printf(p, "    operation_mode: %d\n", as_sdp->mode);
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-04-27 12:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24  9:34 [RESEND PATCH 0/7] AS SDP cleanups and additions for Panel Replay + VRR Ankit Nautiyal
2026-04-24  9:34 ` [RESEND PATCH 1/7] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-24  9:34 ` [RESEND PATCH 2/7] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-24  9:34 ` [RESEND PATCH 3/7] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-24  9:34 ` [RESEND PATCH 4/7] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-24  9:34 ` [RESEND PATCH 5/7] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-27 12:42   ` Ville Syrjälä
2026-04-27 12:52     ` Jani Nikula
2026-04-28  7:48       ` Nautiyal, Ankit K
2026-04-28  7:43     ` Nautiyal, Ankit K
2026-04-24  9:34 ` [RESEND PATCH 6/7] drm/dp: Add a helper to get the SDP type as a string Ankit Nautiyal
2026-04-27 12:57   ` Ville Syrjälä
2026-04-28  7:42     ` Nautiyal, Ankit K
2026-04-24  9:34 ` [RESEND PATCH 7/7] drm/dp: Add target_rr_divider field in AS SDP logging Ankit Nautiyal
2026-04-27 12:58   ` Ville Syrjälä [this message]
2026-04-24 10:22 ` ✗ CI.checkpatch: warning for AS SDP cleanups and additions for Panel Replay + VRR Patchwork
2026-04-24 10:23 ` ✓ CI.KUnit: success " Patchwork
2026-04-24 11:19 ` ✓ i915.CI.BAT: " Patchwork
2026-04-24 11:29 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-24 12:35 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-24 14:31 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae9dk1xLGfCF-ZH3@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.