All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Jan Kara <jack@suse.cz>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dcache: use QSTR() instead of QSTR_INIT()
Date: Mon, 27 Apr 2026 15:58:58 +0200	[thread overview]
Message-ID: <ae9rorhAVHKr00TO@linux.dev> (raw)
In-Reply-To: <4pinx2ihfsrbk5wypfhfx46p3g4wd3ko3i6dxqyy64m7fquzqy@dnob2jlgqqt3>

On Wed, Apr 22, 2026 at 02:51:19PM +0200, Jan Kara wrote:
> On Wed 22-04-26 14:33:46, Thorsten Blum wrote:
> > Drop the hard-coded length arguments and use the simpler QSTR().
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> 
> Sure. Feel free to add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Hi Jan,

This should probably be dropped as it doesn't compile on architectures
where strlen() cannot be folded to a constant at compile time (e.g.,
arch/sh, arch/arc).

Thanks,
Thorsten

  reply	other threads:[~2026-04-27 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 12:33 [PATCH] dcache: use QSTR() instead of QSTR_INIT() Thorsten Blum
2026-04-22 12:51 ` Jan Kara
2026-04-27 13:58   ` Thorsten Blum [this message]
2026-04-22 14:34 ` Al Viro
2026-04-22 15:04   ` Jan Kara
2026-04-22 15:41     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae9rorhAVHKr00TO@linux.dev \
    --to=thorsten.blum@linux.dev \
    --cc=brauner@kernel.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.