From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: Yosry Ahmed <yosry@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/6] KVM: x86/pmu: Re-evaluate Host-Only/Guest-Only on nested SVM transitions
Date: Wed, 15 Apr 2026 17:29:40 -0700 [thread overview]
Message-ID: <aeAtdIPo-8uk8nvH@google.com> (raw)
In-Reply-To: <CALMp9eSHJmLLAQAvbvRmq99v568PGkJduoQn1djnXGb-yED_5g@mail.gmail.com>
On Wed, Apr 15, 2026, Jim Mattson wrote:
> On Wed, Apr 15, 2026 at 2:26 PM Sean Christopherson <seanjc@google.com> wrote:
> > On Thu, Apr 09, 2026, Jim Mattson wrote:
> > > When would we use the deferred version? As far as the Intel PMU is
> > > concerned. there's nothing special about a nested transition.
> >
> > Actually, outside of VMRUN=>#VMEXIT, isn't the deferred version correct? E.g.
> > when counting instructions, shouldn't WRMSR(EFER) be accounted based on the *old*
> > EFER value, not the new EFER value?
>
> Unless you can point to documentation stating otherwise, I think this
> needs testing. By analogy with VMRUN and #VMEXIT, accounting should be
> based on the CPU state at instruction retirement.
IMO, VMRUN and #VMEXIT are broken :-)
But yeah, +1 to following what hardware does. I was thinking we could look at
our KUT and selftests code, but AFAICT all of the precise measurements are
bookended by WRMSRs, so an off-by-one on the frontend would be corrected by the
off-by-one on the backend.
next prev parent reply other threads:[~2026-04-16 0:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 3:11 [PATCH v4 0/6] KVM: x86/pmu: Add support for AMD Host-Only/Guest-Only bits Yosry Ahmed
2026-03-26 3:11 ` [PATCH v4 1/6] KVM: x86: Move enable_pmu/enable_mediated_pmu to pmu.h and pmu.c Yosry Ahmed
2026-03-26 3:11 ` [PATCH v4 2/6] KVM: x86: Move guest_mode helpers to x86.h Yosry Ahmed
2026-03-26 22:48 ` kernel test robot
2026-03-26 23:18 ` Yosry Ahmed
2026-03-27 3:15 ` kernel test robot
2026-03-26 3:11 ` [PATCH v4 3/6] KVM: x86/pmu: Disable counters based on Host-Only/Guest-Only bits in SVM Yosry Ahmed
2026-04-07 1:30 ` Sean Christopherson
2026-04-24 6:55 ` Yosry Ahmed
2026-04-27 18:50 ` Sean Christopherson
2026-04-27 19:11 ` Yosry Ahmed
2026-04-27 19:54 ` Sean Christopherson
2026-04-27 20:02 ` Yosry Ahmed
2026-04-27 20:06 ` Sean Christopherson
2026-04-27 23:20 ` Yosry Ahmed
2026-04-27 23:53 ` Sean Christopherson
2026-04-28 0:34 ` Yosry Ahmed
2026-04-28 0:35 ` Yosry Ahmed
2026-04-28 0:37 ` Yosry Ahmed
2026-03-26 3:11 ` [PATCH v4 4/6] KVM: x86/pmu: Re-evaluate Host-Only/Guest-Only on nested SVM transitions Yosry Ahmed
2026-04-07 1:35 ` Sean Christopherson
2026-04-09 4:59 ` Jim Mattson
2026-04-09 17:22 ` Sean Christopherson
2026-04-09 17:29 ` Jim Mattson
2026-04-09 17:48 ` Sean Christopherson
2026-04-09 18:35 ` Jim Mattson
2026-04-09 18:38 ` Sean Christopherson
2026-04-09 21:21 ` Sean Christopherson
2026-04-10 3:50 ` Jim Mattson
2026-04-15 21:26 ` Sean Christopherson
2026-04-15 23:07 ` Jim Mattson
2026-04-16 0:29 ` Sean Christopherson [this message]
2026-04-17 22:51 ` Jim Mattson
2026-04-21 20:01 ` Yosry Ahmed
2026-04-22 22:42 ` Sean Christopherson
2026-04-24 6:57 ` Yosry Ahmed
2026-03-26 3:11 ` [PATCH v4 5/6] KVM: x86/pmu: Allow Host-Only/Guest-Only bits with nSVM and mediated PMU Yosry Ahmed
2026-03-26 3:11 ` [PATCH v4 6/6] KVM: selftests: Add svm_pmu_host_guest_test for Host-Only/Guest-Only bits Yosry Ahmed
2026-04-07 1:39 ` Sean Christopherson
2026-04-07 3:23 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeAtdIPo-8uk8nvH@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.