From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Daniel Palmer <daniel@thingy.jp>
Cc: angelo@kernel-space.org, bmeng.cn@gmail.com, sjg@chromium.org,
u-boot@lists.denx.de
Subject: Re: [PATCH v4 4/6] virtio: cmd: Depend on VIRTIO_BLK
Date: Thu, 16 Apr 2026 17:27:05 +0800 [thread overview]
Message-ID: <aeCraTEweq9R0isP@google.com> (raw)
In-Reply-To: <20260413092240.3719260-5-daniel@thingy.jp>
On Mon, Apr 13, 2026 at 06:22:38PM +0900, Daniel Palmer wrote:
> The virtio command is calling virtio blk functions but currently
> depends on CONFIG_VIRTIO only. This means disabling CONFIG_VIRTIO_BLK
> causes the final link to fail.
>
> Since CONFIG_VIRTIO_BLK depends on CONFIG_VIRTIO switch to depending
> on just CONFIG_VIRTIO_BLK
>
> Signed-off-by: Daniel Palmer <daniel@thingy.jp>
Reviewed-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Regards,
Kuan-Wei
> ---
> cmd/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 7bbeaad04ff4..7c86164ddb20 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1863,8 +1863,8 @@ config CMD_PVBLOCK
>
> config CMD_VIRTIO
> bool "virtio"
> - depends on VIRTIO
> - default y if VIRTIO
> + depends on VIRTIO_BLK
> + default y if VIRTIO_BLK
> help
> VirtIO block device support
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-04-16 9:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 9:22 [PATCH v4 0/6] Add virtio-mmio support to m68k virt machine Daniel Palmer
2026-04-13 9:22 ` [PATCH v4 1/6] sysreset: qemu virt: Use __raw_writel() Daniel Palmer
2026-04-13 9:22 ` [PATCH v4 2/6] m68k: Fix writew(), writel(), readw(), readl() endianness for classic m68k Daniel Palmer
2026-04-16 9:06 ` Angelo Dureghello
2026-04-16 9:14 ` Daniel Palmer
2026-04-16 9:25 ` Kuan-Wei Chiu
2026-04-13 9:22 ` [PATCH v4 3/6] virtio: mmio: Allow instantiation via platform data Daniel Palmer
2026-04-16 9:09 ` Angelo Dureghello
2026-04-16 9:26 ` Kuan-Wei Chiu
2026-04-13 9:22 ` [PATCH v4 4/6] virtio: cmd: Depend on VIRTIO_BLK Daniel Palmer
2026-04-13 15:03 ` Simon Glass
2026-04-14 19:23 ` Tom Rini
2026-04-16 9:09 ` Angelo Dureghello
2026-04-16 9:27 ` Kuan-Wei Chiu [this message]
2026-04-13 9:22 ` [PATCH v4 5/6] virtio: blk: Fix converting the vendor id to a string Daniel Palmer
2026-04-16 9:28 ` Kuan-Wei Chiu
2026-04-13 9:22 ` [PATCH v4 6/6] board: qemu: m68k: Create virtio mmio instances Daniel Palmer
2026-04-13 15:04 ` Simon Glass
2026-04-16 9:17 ` Angelo Dureghello
2026-04-16 9:29 ` Kuan-Wei Chiu
2026-04-16 7:19 ` [PATCH v4 0/6] Add virtio-mmio support to m68k virt machine Kuan-Wei Chiu
2026-04-16 9:15 ` Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeCraTEweq9R0isP@google.com \
--to=visitorckw@gmail.com \
--cc=angelo@kernel-space.org \
--cc=bmeng.cn@gmail.com \
--cc=daniel@thingy.jp \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.