All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: John Garry <john.g.garry@oracle.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"nilay@linux.ibm.com" <nilay@linux.ibm.com>
Subject: Re: [PATCH blktests] nvme/068: add a test for multipath delayed removal
Date: Fri, 17 Apr 2026 02:22:09 +0000	[thread overview]
Message-ID: <aeGYt5LeJFmW2VQD@shinmob> (raw)
In-Reply-To: <b00f7f6d-278f-457e-9151-7528ef7d61b4@oracle.com>

On Apr 16, 2026 / 14:03, John Garry wrote:
> On 16/04/2026 13:50, Shinichiro Kawasaki wrote:
[...]
> > John, thanks for the patch. When I ran the new test case in my test environment,
> > it failed. The reported refcount mismatch looks happening in the Part b.
> > 
> > nvme/068 (tr=loop) (NVMe multipath delayed removal test)     [failed]
> >      runtime  38.579s  ...  38.770s
> >      --- tests/nvme/068.out      2026-04-16 20:50:21.228000000 +0900
> >      +++ /home/shin/Blktests/blktests/results/nodev_tr_loop/nvme/068.out.bad     2026-04-16 21:30:36.215000000 +0900
> >      @@ -1,3 +1,4 @@
> >       Running nvme/068
> >       pwrite: Input/output error
> >      +module refcount not as original
> >       Test complete
> > 
> > I have no idea why it fails. Do you have any guess about the failure cause?
> 
> I posted a fix for this here:
> https://lore.kernel.org/linux-nvme/20260416051459.GA14802@lst.de/T/#m17eb549aba102198009a37621cb45775841639d9

Thanks. With the kenrel fix, I confirmed that the test case passes. Good.

[...]

> About this specific part of the test (checking module refcnt), I was
> wondering if we should be testing kernel internals like this. But, since it
> found a problem, I suppose that makes it ok :)

Agreed, this test case already proved its value :)

  reply	other threads:[~2026-04-17  2:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 10:41 [PATCH blktests] nvme/068: add a test for multipath delayed removal John Garry
2026-04-15 17:58 ` Chaitanya Kulkarni
2026-04-16 11:18 ` Nilay Shroff
2026-04-16 11:45   ` John Garry
2026-04-16 12:50 ` Shinichiro Kawasaki
2026-04-16 13:03   ` John Garry
2026-04-17  2:22     ` Shinichiro Kawasaki [this message]
2026-04-27 12:17 ` Daniel Wagner
2026-04-27 12:51   ` John Garry
2026-04-28 12:42     ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeGYt5LeJFmW2VQD@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.