From: "Anthony PERARD" <anthony.perard@vates.tech>
To: "Teddy Astie" <teddy.astie@vates.tech>
Cc: xen-devel@lists.xenproject.org,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>,
"Community Manager" <community.manager@xenproject.org>
Subject: Re: [PATCH v10] xenpm: Add get-core-temp subcommand
Date: Fri, 17 Apr 2026 08:57:37 +0000 [thread overview]
Message-ID: <aeH1_5V71IQCbgCI@l14> (raw)
In-Reply-To: <22bcde2914c0303b2c594485542af19d2952e782.1775570823.git.teddy.astie@vates.tech>
On Tue, Apr 07, 2026 at 02:10:37PM +0000, Teddy Astie wrote:
> + for ( cpu = 0; cpu < max_cpu_nr; cpu += physinfo.threads_per_core )
> + {
> + if ( fetch_dts_temp(xc_handle, cpu, false, &temp) )
> + {
> + fprintf(stderr, "[CPU%d] Unable to fetch temperature (%d - %s)\n",
> + cpu, errno, strerror(errno));
> + continue;
> + }
> +
A trailing whitespace was introduced here since v9.
> + has_data = true;
> + printf("CPU%d: %d°C\n", cpu, temp);
> + }
Beside that, patch looks good to me now:
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
| Vates
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
prev parent reply other threads:[~2026-04-17 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:10 [PATCH v10] xenpm: Add get-core-temp subcommand Teddy Astie
2026-04-08 12:34 ` Jan Beulich
2026-04-08 13:13 ` Teddy Astie
2026-04-21 7:24 ` Oleksii Kurochko
2026-04-17 8:57 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeH1_5V71IQCbgCI@l14 \
--to=anthony.perard@vates.tech \
--cc=community.manager@xenproject.org \
--cc=oleksii.kurochko@gmail.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.