Re: [PATCH v3 4/4] tests/unit: add pread/pwrite _all tests for io channel file

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Apr 14, 2026 at 05:45:49AM +0800, Junjie Cao wrote:
> Add unit tests for the new qio_channel_pread{v,}_all{,_eof}() and
> qio_channel_pwrite{v,}_all() APIs.
> 
> The basic tests write data to a file channel, then read it back at
> various offsets using both the single-buffer and iovec variants to
> make sure the round-trip produces identical content.  The _eof tests
> verify all three return cases -- full read (1), clean EOF (0), and
> partial-then-EOF (-1 with error set) -- and check that the strict
> wrappers (preadv_all / pread_all) treat a clean EOF as an error.
> 
> All tests are guarded by CONFIG_PREADV since the underlying channel
> methods require preadv(2).
> 
> Signed-off-by: Junjie Cao <junjie.cao@intel.com>
> ---
>  tests/unit/test-io-channel-file.c | 207 ++++++++++++++++++++++++++++++
>  1 file changed, 207 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|