All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao Xiang <xiang@kernel.org>
To: Yifan Zhao <stopire@gmail.com>
Cc: Gao Xiang <hsiangkao@linux.alibaba.com>,
	linux-erofs@lists.ozlabs.org, oliver.yang@linux.alibaba.com,
	Yuxuan Liu <cdjddzy@foxmail.com>
Subject: Re: [PATCH 1/2] erofs-utils: mount: support mounting EROFS stored as an AWS S3 object
Date: Sat, 18 Apr 2026 00:20:03 +0800	[thread overview]
Message-ID: <aeJds46XjTU2rx2C@debian> (raw)
In-Reply-To: <f4edfc67-0c4a-49c6-ac15-5821c9b467d3@gmail.com>

On Fri, Apr 17, 2026 at 10:15:30PM +0800, Yifan Zhao wrote:
> 
> On 4/17/2026 6:18 PM, Gao Xiang wrote:

...

 > @@ -1106,7 +1263,7 @@ static int erofsmount_startnbd_nl(pid_t *pid, struct erofsmount_source *source)
> >   				}
> >   			}
> >   		}
> > -		erofs_io_close(&ctx.vd);
> > +		erofs_io_close(ctx.vd);
> >   out_fork:
> >   		(void)unlink(recp);
> >   		free(recp);
> > @@ -1186,13 +1343,13 @@ static int erofsmount_reattach(const char *target)
> 
> In erofsmount_reattach() we should:
> 
>     `struct erofsmount_nbd_ctx ctx = {};` => `struct erofsmount_nbd_ctx ctx
> = {.vd = &ctx._vd};`
> 
> otherwise uninitialized ctx.vd leads to segfault.

Thanks, fixed.

Thanks,
Gao Xiang

> 
> 
> Thanks,
> 
> Yifan Zhao
> 


      reply	other threads:[~2026-04-17 16:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17 10:18 [PATCH 1/2] erofs-utils: mount: support mounting EROFS stored as an AWS S3 object Gao Xiang
2026-04-17 10:18 ` [PATCH 2/2] erofs-utils: mount: add recovery support for S3 object mounts Gao Xiang
2026-04-17 14:15 ` [PATCH 1/2] erofs-utils: mount: support mounting EROFS stored as an AWS S3 object Yifan Zhao
2026-04-17 16:20   ` Gao Xiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeJds46XjTU2rx2C@debian \
    --to=xiang@kernel.org \
    --cc=cdjddzy@foxmail.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=oliver.yang@linux.alibaba.com \
    --cc=stopire@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.