From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E811F99C74 for ; Sat, 18 Apr 2026 03:44:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wDwaf-000773-En; Fri, 17 Apr 2026 23:43:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wDwad-00075l-Ks for qemu-arm@nongnu.org; Fri, 17 Apr 2026 23:43:27 -0400 Received: from mail-vk1-xa43.google.com ([2607:f8b0:4864:20::a43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wDwab-000234-7u for qemu-arm@nongnu.org; Fri, 17 Apr 2026 23:43:27 -0400 Received: by mail-vk1-xa43.google.com with SMTP id 71dfb90a1353d-56a857578a8so503409e0c.3 for ; Fri, 17 Apr 2026 20:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776483803; x=1777088603; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gf+jNGWsKroQLTB6YzgFMpQGPeobJncLTcLFEvWLsr8=; b=i2YAv9ksxfhA20oQPB1uMpinHbrmJeNnAQee+Na1rt3Bq76OM+w9gl2buiK6M7EpSy MdNGoaw9yHBPpKuSVpRKJFeYekSIh0q4eFICO7/BtSw0+3mGbe4e0L007Y8/RvZ/cJFN K0A80bHKEIL/OWT2581QxwEpq9DI/n7LHE2gUR1sAJQZUkaB8eOpYcc6m4uxXwxrPxyc xx8di6EtxZKdugiZFjwnpBNO+g4Y9hadnMW+iWRvNoQdB6aCnR4kFUi5G2LwDe/zDtz8 g0LcDhEzjzul+Jrdv+jKZje7XT5rYz5mH7sX+mk6gI+wLoAkicocQa1rPtjRyDzeFSqq al/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776483803; x=1777088603; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gf+jNGWsKroQLTB6YzgFMpQGPeobJncLTcLFEvWLsr8=; b=tIB46vLLeBQ/np5/bqsuOVuOPJupepXaWT9TLfdK30LeOUM4GVitEZ9g5aor/dNIJr sCMdqLc9i3NGHfPIbWe2RmlftDLn3cHfZEPk1XS2kiacpA2q34gjcNeHHbtEIpFIK5Di zBb6Zhi+GYsQ+sem8bPuhGL81I3X6bVgvm8e+mRbKDM67IsmAM+uYnHkAK4G8rsErrc/ jVMn2OsLrDswyfIV79APWQQ9q9ONs9AEvVF1f3cfv9lHcIze7pNvTFjagQEpZY/AWwL9 QACPh2qNPLbZe7ZmcpoioGlz71X5i42YhW1Pq52c+LgQWdxgEOiewUvEJ7gLX/1DR8l4 JwEQ== X-Gm-Message-State: AOJu0YwAFxeguwq8nJLbB7I2S16cG55MuJqOUwNGnQ87TwYp2t6LTWT6 pZqOF7FnRnZEc7rFJzzton/zynAGJqYz/3Fmc5sTDIYYoxBiVpfqPUBl X-Gm-Gg: AeBDievEK9+9IiSFueqlXKo6Yg6arKWN8J5TGEKfJOKGaOmeeOgB/TUhsyDr82/ctmB 8lWYShf4OOi96B5ipEkRHrN3zgEOxNsFwtB1wBHlcIgSMDNI2h3TMLMiCjthh7T9rkZfi1U7xjK xxII3SigC0MYXbDzZD12nB4Cce1mC9flnSpuJ1rOmxf6Ctf6BPtPBPUFjbvQ7hhGdrQcTKN9uP/ dcWpSBXZp3XMmCLmVRELTlzgTJ7bOaQB/jL5NZhePkMHW7agkai01fdsmGeg6F0PDsAcWDBC+G1 CzKfT5gyZ4oPwhEGMOTHGnyV+qnpoQ58PZMYwSkuiWrsKfR1keeUmR4u+Z3tx2QTbrAV8HiifGm Rru1+KRvofyMpO6HQVNTpWwh1zZbtjauoKJ2dRgbkunXDR1s84axrWCdai+MDhTwIzzC0OPFRhO 2VNrt6RNEVFar+lY4J0ELq6k7arqeRgfIj4SW8szQ1aT+BzDAXEiCcnotbqd1Nv/vmtshaiut8l vnBK9v+dkU= X-Received: by 2002:a05:6102:2927:b0:608:9a34:c8ea with SMTP id ada2fe7eead31-616f68d7618mr2747367137.10.1776483802867; Fri, 17 Apr 2026 20:43:22 -0700 (PDT) Received: from ZEVORN-PC.localdomain ([162.244.208.119]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9589097ec5csm1719242241.4.2026.04.17.20.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 20:43:21 -0700 (PDT) Date: Sat, 18 Apr 2026 11:43:00 +0800 From: Chao Liu To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Marcel Apfelbaum , Yanan Wang , Zhao Liu , Paolo Bonzini , Richard Henderson , "Dr. David Alan Gilbert" , Alex =?utf-8?Q?Benn=C3=A9e?= , Alexandre Iooss , Mahmoud Mandour , Peter Xu , "Edgar E. Iglesias" , Jiaxun Yang , Nicholas Piggin , Chinmay Rath , Glenn Miles , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Ilya Leoshkevich , David Hildenbrand , Mark Cave-Ayland , Artyom Tarasenko Subject: Re: [PATCH 01/17] target/riscv: Make get_phys_page_debug handle non-page-aligned addrs Message-ID: References: <20260417173105.1648172-1-peter.maydell@linaro.org> <20260417173105.1648172-2-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260417173105.1648172-2-peter.maydell@linaro.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::a43; envelope-from=chao.liu.zevorn@gmail.com; helo=mail-vk1-xa43.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Fri, Apr 17, 2026 at 06:30:49PM +0100, Peter Maydell wrote: > Currently our implementations of SysemuCPUOps::get_phys_page_debug > and SysemuCPUOps::get_phys_page_attrs_debug are a mix of "accepts a > non-page-aligned virtual address and returns the corresponding > non-page-aligned physical address" and "only returns a page-aligned > physical address". This is awkward for callsites, which in practice > all want the physical address for an arbitrary virtual address and > have to work around the possibility of getting a page-aligned > address, and it doesn't account for protection being possibly on a > sub-page-sized granularity. We want to standardize on the > implementation having to handle non-page-aligned addresses. > > The only thing in the riscv implementation that we need to fix > is the place where we explicitly round the return value down to > a page boundary before returning it. Drop that. > > Signed-off-by: Peter Maydell Reviewed-by: Chao Liu Thanks, Chao > --- > target/riscv/cpu_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c > index dd6c861a90..475e9cfd57 100644 > --- a/target/riscv/cpu_helper.c > +++ b/target/riscv/cpu_helper.c > @@ -1677,7 +1677,7 @@ hwaddr riscv_cpu_get_phys_page_debug(CPUState *cs, vaddr addr) > } > } > > - return phys_addr & TARGET_PAGE_MASK; > + return phys_addr; > } > > void riscv_cpu_do_transaction_failed(CPUState *cs, hwaddr physaddr, > -- > 2.43.0 >