From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: arp_tables: fix IEEE1394 ARP payload mangling
Date: Sat, 18 Apr 2026 10:10:24 +0200 [thread overview]
Message-ID: <aeM8cJSTHEt9PRy3@strlen.de> (raw)
In-Reply-To: <aeMyhUwPwj2kB6Xa@chamomile>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Florian,
>
> On Fri, Apr 17, 2026 at 03:19:05PM +0200, Florian Westphal wrote:
> > sashiko.dev noticed that similar bug pattern exists in arpt_mangle:
> > "IEEE1394 ARP payloads omit the target hardware address, advancing
> > arpptr by hln after the source IP address skips over the actual target
> > IP address."
> >
> > Apply similar fix: check dev->type. If we're asked to mangle what
> > doesn't exist, drop the packet.
>
> I included a fix for this in:
>
> https://patchwork.kernel.org/project/netdevbpf/patch/20260417091422.342615-1-pablo@netfilter.org/
I saw that *after* I had made this patch.
> > Collides with a inflight patch.
>
> Are you referring to the patch I made?
Yes.
prev parent reply other threads:[~2026-04-18 8:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 13:19 [PATCH nf] netfilter: arp_tables: fix IEEE1394 ARP payload mangling Florian Westphal
2026-04-18 7:28 ` Pablo Neira Ayuso
2026-04-18 8:10 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeM8cJSTHEt9PRy3@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.