All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <ljs@kernel.org>
To: Nick Huang <sef1548@gmail.com>
Cc: Vlastimil Babka <vbabka@kernel.org>, Harry Yoo <harry@kernel.org>,
	 Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	 Jonathan Corbet <corbet@lwn.net>, Hao Li <hao.li@linux.dev>,
	Christoph Lameter <cl@gentwo.org>,
	 David Rientjes <rientjes@google.com>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	 "Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Mike Rapoport <rppt@kernel.org>,
	 Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	 Shuah Khan <skhan@linuxfoundation.org>,
	linux-mm@kvack.org, linux-doc@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: Add overview and SLUB allocator sections to slab documentation
Date: Sat, 18 Apr 2026 10:07:22 +0100	[thread overview]
Message-ID: <aeNGbNyPxJssnkbO@lucifer> (raw)
In-Reply-To: <20260418000635.17499-1-sef1548@gmail.com>

NAK to obvious, disrespectful, AI slop garbage.

Go read https://docs.kernel.org/process/generated-content.html - especially the
bit about dismissing crap like this.

On Sat, Apr 18, 2026 at 12:06:19AM +0000, Nick Huang wrote:
> - Add "Overview" section explaining the slab allocator's role and purpose
> - Document the three main slab allocator implementations (SLAB, SLUB, SLOB)

The fact you're insanely wrong about the current state of slab only makes this
worse.

> - Highlight SLUB as the default allocator on modern systems

Not default. Only...

> - Add "SLUB Allocator" subsection with detailed information:

There's nothing detailed...

> - Explain SLUB's design goals and advantages over legacy SLAB

Irrelevant, SLAB doesn't exist.

> - Document its focus on simplification and performance

Who cares? This isn't linked in?

> - Note support for both uniprocessor and SMP systems

Uniprocessor? Seriously?

>
> Signed-off-by: Nick Huang <sef1548@gmail.com>
> ---
>  Documentation/mm/slab.rst | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/mm/slab.rst b/Documentation/mm/slab.rst
> index 2bcc58ada302..2d1d093afb7b 100644
> --- a/Documentation/mm/slab.rst
> +++ b/Documentation/mm/slab.rst
> @@ -4,6 +4,32 @@
>  Slab Allocation
>  ===============
>
> +Overview
> +========
> +
> +The slab allocator is responsible for efficient allocation and reuse of
> +small kernel objects. It reduces internal fragmentation and improves
> +performance by caching frequently used objects.

This sentence doesn't even make any sense.

> +
> +The Linux kernel provides multiple slab allocator implementations,
> +including SLAB, SLUB, and SLOB. Among these, SLUB is the default
> +allocator on most modern systems.

WRONG. WRONG. WRONG.

> +
> +SLUB Allocator
> +==============
> +
> +Overview
> +--------
> +
> +SLUB is a slab allocator designed to replace the legacy SLAB allocator
> +(mm/slab.c). It addresses the complexity, scalability limitations, and
> +memory overhead of the SLAB implementation.

This is useless crap? 'X is designed to replace Y which doesn't exist but let's
mention it anyway'. How is this an overview?

> +
> +The primary goal of SLUB is to simplify slab allocation while improving
> +performance on both uniprocessor (UP) and symmetric multiprocessing (SMP)
> +systems.

This is meaningless noise too.

> +
> +
>  Functions and structures
>  ========================
>
> --
> 2.43.0
>

You've wasted my time, your time and other people's time. Have a think about
that.

Lorenzo

  parent reply	other threads:[~2026-04-18  9:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-18  0:06 [PATCH] docs: Add overview and SLUB allocator sections to slab documentation Nick Huang
2026-04-18  5:04 ` Matthew Wilcox
2026-04-18  5:27   ` Nick Huang
2026-04-18  6:12     ` Nick Huang
2026-04-18  9:11       ` Lorenzo Stoakes
2026-04-18 11:00         ` Nick Huang
2026-04-18 11:20           ` Vlastimil Babka (SUSE)
2026-04-18 15:30             ` Harry Yoo (Oracle)
2026-04-18  6:19 ` Harry Yoo (Oracle)
2026-04-18  9:07 ` Lorenzo Stoakes [this message]
2026-04-18 16:15   ` Matthew Wilcox
2026-04-19  8:35     ` David Hildenbrand (Arm)
2026-04-19 13:17       ` Lorenzo Stoakes
2026-04-20  4:52         ` Nick Huang
2026-04-20  6:42           ` Mike Rapoport
2026-04-20 10:41             ` Nick Huang
2026-04-20  6:43           ` Jonathan Corbet
2026-04-20 10:43             ` Nick Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeNGbNyPxJssnkbO@lucifer \
    --to=ljs@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@gentwo.org \
    --cc=corbet@lwn.net \
    --cc=david@kernel.org \
    --cc=hao.li@linux.dev \
    --cc=harry@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rppt@kernel.org \
    --cc=sef1548@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.