From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F8B40DFA0 for ; Sun, 19 Apr 2026 20:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776631843; cv=none; b=Uhj3xN2PaRDdnDtOg5m69z8swOmOciUv0uh6i3w+AOVHQOkpWe6gnHjhz+QgqsA/pcFLJ/8wsn7yKZ9/emNI2ftOlewjsoyiwVoCZollLMW9VpsVE9cpBAkaq8ZcJeOeArjy1d57LQumqmqqyWnpmm/RoU4NE9c775DbgjyF/u0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776631843; c=relaxed/simple; bh=EGJ4d7aBThk6+KKsvBN4dacEjhoniiJMmY6acpVLKyA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NN6lIvLapPaiG4mlOKRhnFF9dqrWzWXGmQ3cZoOeESO1JAotrRFCUfQACBlqLDnCtkj8xrscf6IRi/SY0ndNEZbGeTLfiACTlT5yySnXOVzkcs+HpUzvFW3fpfBDXW0+OEEdVvmZeTdp/Y/wgwxGb7eeoQbbuL79eLOXv4pnp6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com; spf=none smtp.mailfrom=readmodwrite.com; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b=JTLmxiBg; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b="JTLmxiBg" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488b0046078so22541775e9.1 for ; Sun, 19 Apr 2026 13:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1776631840; x=1777236640; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F8jW6CjPy1p8vIsI5l4OpyiRRY6WDX+zovIrb3Ob5Qg=; b=JTLmxiBgTB6503NpXadJSdah8N1XgH86gdYnwaNGAPymE0mAZONXTi5w0oVfSZmNiN 5dbh9soOJKgxvJ5xy9wTKYsQk7YIz2ZaHDpKksSSDXryWcjLuzcrBPfYQ/wogtgZIxPJ FI04qj3RohzRXd8fcPjP7pCWtAomPi9tehHe371aUJwqPmjj52/hQQyrRvydEEvdbqbQ a54Z/DLSfUE9Ib/VvCGxsOpmv87aNw49F2AiOO4t+uxu4l3xYvetUkm/b4Wr+RolA0Ha wl5C9qng0nFmcbtOGv94/ojqichuqIwreT/34CDgEsxYJEg5j9Be4RI2xdhe/PijjhCl HoLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776631840; x=1777236640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F8jW6CjPy1p8vIsI5l4OpyiRRY6WDX+zovIrb3Ob5Qg=; b=T0eUuhOvzLtgLF5eoxrI335dhqTR3j5ZVHkCP6Q7Qjiq0kolJzVSLhyu/bl8Ejstbe GGwX1IY2psaWPrPehFSgct2iGN9rFVpS0vdc65e257v/oC3NI1n2ShOSoA60hzcplzoK TjM5LdK+bgI+sW15TY8xkSIN7aZi6ISmNE3CXzn3lx55jjE8zjP0JZ1WVxEUAHcGLc0c kKFXKo8VKcMYfti0gxPwP/YyxtE/rGbTWgf/KHdyWmQkk+jr5g5/wTMoLRZ2+opP6pHq jGw8OowNSemqx7lVyhXqo3sBzysEgk/CLYJvIXvvcNNjh+pqAvNJnF9z6KyJfmaYnPbn sz9A== X-Forwarded-Encrypted: i=1; AFNElJ/ugJsq/GpmcG5fcqT148yZkGbKkWUQqObdb/3l5dysqT9H3+STMKJwUszKop7hMeRQV7a2R81P2y/rt1Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwDUbX99LN7laoUVWQ3GNxQmKujRdllMm6CtuYPUvTGYBzrktdu kMDAnZz7jmlpXhAlP/29E09MAeoeaaYe2HeiJnA7m0m4e7vn9bs38fsNHLsuu3rsEKo= X-Gm-Gg: AeBDietUCIR1UTyK1HUa5AWcVmetnzDYcHm0XNCwdHLWFlY30mexXoop+wfjSDhOyCh nClRL7SwfzrRPSBIAOLDXHDEP0ANjEDYhkCteJzGxDMXrHoLRdi8LPZUdr1NKXm4vsshXyadIbN Pq3gb5tpVL8bNaCdH8NgjOdUmVYA455PNFLKFikhvKSreYm9ivWHfpO46pqmemE1rKXCoPvNbue ckiABB1iyhLFdtLJEk9hWrwO6lQonGRcjpd3psk02AZmYLcjSf0zf505c+pMCWDNxsWabg7+4ed eryh8F/l52ONda/GRClHRtaljCIY6uMXZ92tgwTBhtk0TZisjPz/llAiXAU50fWqHdJGrfuVKHV 0fNFgBd5IgksOjtf2N9LsCkqj6BS5RGgiUu2AGHQBO4skPEZw3/KMb2PvDWFXCpIBGDdTtc97Nv QL2Cmp4nsEN7zTP+RWeg== X-Received: by 2002:a05:600c:498a:b0:489:ad:7b5b with SMTP id 5b1f17b1804b1-48900ad7b76mr57498225e9.24.1776631840357; Sun, 19 Apr 2026 13:50:40 -0700 (PDT) Received: from localhost ([2a09:bac6:37a8:d2::15:3d7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4891df9e50asm8444435e9.0.2026.04.19.13.50.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2026 13:50:39 -0700 (PDT) Date: Sun, 19 Apr 2026 21:50:38 +0100 From: Matt Fleming To: Corey Minyard Cc: Tony Camuso , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Matt Fleming , Frederick Lawler Subject: Re: [PATCH] ipmi: Add timeout to unconditional wait in __get_device_id() Message-ID: References: <20260415115930.3428942-1-matt@readmodwrite.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 17, 2026 at 06:53:55PM -0500, Corey Minyard wrote: > > The EVENT_MSG_BUFFER_FULL flag only gets cleared when a unsuccessful > READ_EVENT_MSG_BUFFER command completes. Getting data from the > BMC has higher priority than sending data to the BMC. > > If the BMC continually reports success from READ_EVENT_MSG_BUFFER, then > that would certainly wedge the driver. But it would have to continually > report success for that command, which would be strange as its supposed > to error out when the queue is empty. That does indeed appear to be what's happening. The implementation of intel-ipmi-oem's OpenBMC READ_EVENT_MSG_BUFFER handler does not fail when there is nothing to read, https://github.com/openbmc/intel-ipmi-oem/blob/master/src/bridgingcommands.cpp#L704 > If it's really something like that, I could also look at adding limits > for those operations. That would be great. Me and Fred would be happy to test out any patch. I still think the original patch I sent is a worthwhile defense. Our periodic monitoring scripts cause TASK_UNINTERRUPTIBLE tasks to block behind one another when we hit these kinds of issues in the IPMI code. Untangling that across thousands of machines can be time consuming and a more explicit EIO or ETIMEDOUT would help with triage.