All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Steinhardt <ps@pks.im>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] Move libgit.a sources into separate "lib/" directory
Date: Mon, 20 Apr 2026 08:41:03 +0200	[thread overview]
Message-ID: <aeXKf901jbfmEOVk@pks.im> (raw)
In-Reply-To: <aeKrXwdnHjhsVQBI@fruit.crustytoothpaste.net>

On Fri, Apr 17, 2026 at 09:51:27PM +0000, brian m. carlson wrote:
> On 2026-04-17 at 21:18:37, Junio C Hamano wrote:
> > I do not mind a move to thin the set of regular files out of the
> > top-level directory.  I have forever been annoyed by my buil<TAB>
> > no longer complete to builtin (anticipating either .h or /) and
> > it would be nice if build.rs is renamed away, or builtin{.h,/}
> > are moved away, to restore the convenience of tab completion back.
> 
> The `build.rs` file needs to go at the same level as the Rust `src`
> directory so `cargo` can invoke it properly.  I think Patrick had wanted
> to put the Rust code in a directory called `rust`, which would move that
> out of the root of the repository and fix that.  As long as it continues
> to build gracefully on a variety of platforms, I think that would be
> okay.

I don't think I was the one proposing the `rust` directory, but I
wouldn't mind that direction, either.

Patrick

  reply	other threads:[~2026-04-20  6:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 13:24 [PATCH RFC 0/2] Move libgit.a sources into separate "lib/" directory Patrick Steinhardt
2026-04-16 13:24 ` [PATCH RFC 1/2] t/helper: prepare "test-example-tap.c" for introduction of "lib/" Patrick Steinhardt
2026-04-16 13:24 ` [PATCH RFC 2/2] Move libgit.a sources into separate "lib/" directory Patrick Steinhardt
2026-04-17 17:08   ` Elijah Newren
2026-04-17 19:18   ` brian m. carlson
2026-04-17 21:18     ` Junio C Hamano
2026-04-17 21:51       ` brian m. carlson
2026-04-20  6:41         ` Patrick Steinhardt [this message]
2026-04-19 14:11 ` [PATCH RFC 0/2] " Phillip Wood
2026-04-20  6:41   ` Patrick Steinhardt
2026-04-20 12:03 ` Derrick Stolee
2026-04-21  5:55   ` Patrick Steinhardt
2026-04-21 14:13     ` Derrick Stolee
2026-04-22  6:39       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeXKf901jbfmEOVk@pks.im \
    --to=ps@pks.im \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.