All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Demir Özdemir" <demirozdemir@disroot.org>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c
Date: Mon, 20 Apr 2026 16:16:17 +0200	[thread overview]
Message-ID: <aeY1Mc2uEUKkr-dB@archlinux> (raw)

Remove redundant else block after a return statement within if block in
rtl8723bs_hal_init(). Identified through checkpatch as a warning.

Signed-off-by: Demir Özdemir <demirozdemir@disroot.org>
---
 drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index f2f73c65a636..809f07855bb8 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -654,11 +654,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
 		padapter->bFWReady = false;
 		pHalData->fw_ractrl = false;
 		return ret;
-	} else {
-		padapter->bFWReady = true;
-		pHalData->fw_ractrl = true;
 	}
 
+	padapter->bFWReady = true;
+	pHalData->fw_ractrl = true;
+
 	rtl8723b_InitializeFirmwareVars(padapter);
 
 /* 	SIC_Init(padapter); */
-- 
2.53.0


             reply	other threads:[~2026-04-20 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 14:16 Demir Özdemir [this message]
2026-04-20 22:47 ` [PATCH] staging: rtl8723bs: remove redundant else block in sdio_halinit.c Ethan Tidmore
2026-04-21 14:34 ` Luka Gejak
2026-04-26 20:10 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeY1Mc2uEUKkr-dB@archlinux \
    --to=demirozdemir@disroot.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.