From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_compat: run checkentry() from .validate
Date: Mon, 20 Apr 2026 21:07:01 +0200 [thread overview]
Message-ID: <aeZ5VYC0cxxVYQ4_@chamomile> (raw)
In-Reply-To: <aeZ2H8ghe3Ddcn9u@strlen.de>
On Mon, Apr 20, 2026 at 08:53:19PM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Your approach duplicates .checkentry in some way, you have to make
> > sure what your .validate and .checkentry perform the same check, ie.
> > they are in sync.
>
> Thats why I updated the affected .checkentry functions to use
> the validate functions internally -- to make sure the code is called
> even for classic iptables.
>
> > If this needs to be generalized further, maybe checkentry() needs to
> > extended to improve integration with nftables.
>
> I hope not. But I don't care, if you prefer your patch then so be it.
I can toss this patch if you prefer, I will post it complete then
decide what to do.
> I just find it sad we duplicate efforts all the time.
I thought I could provide a more self-contained approach for this
nft_compat specific bug.
prev parent reply other threads:[~2026-04-20 19:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 17:42 [PATCH nf] netfilter: nft_compat: run checkentry() from .validate Pablo Neira Ayuso
2026-04-20 17:55 ` Florian Westphal
2026-04-20 17:59 ` Pablo Neira Ayuso
2026-04-20 18:21 ` Florian Westphal
2026-04-20 18:48 ` Pablo Neira Ayuso
2026-04-20 18:53 ` Florian Westphal
2026-04-20 19:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeZ5VYC0cxxVYQ4_@chamomile \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.