All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: alistair23@gmail.com
Cc: hare@suse.de, hch@lst.de, sagi@grimberg.me, kch@nvidia.com,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	yi.zhang@redhat.com, mlombard@arkamax.eu,
	linux-block@vger.kernel.org, shinichiro.kawasaki@wdc.com,
	Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH 1/2] Revert "nvmet-tcp: Don't free SQ on authentication success"
Date: Mon, 20 Apr 2026 10:23:44 -0600	[thread overview]
Message-ID: <aeZTEAYE6uryLbuf@kbusch-mbp> (raw)
In-Reply-To: <20260417004809.2894745-1-alistair.francis@wdc.com>

On Fri, Apr 17, 2026 at 10:48:08AM +1000, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
> 
> In an attempt to fix REPLACETLSPSK we stopped freeing the secrets on
> successful connections. This resulted in memory leaks in the kernel, so
> let's revert the commit. A improved fix is being developed to just avoid
> clearing the tls_key variable.
> 
> This reverts commit 2e6eb6b277f593b98f151ea8eff1beb558bbea3b.

Thanks, patches 1 and 2 applied to nvme-7.1.

      parent reply	other threads:[~2026-04-20 16:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-17  0:48 [PATCH 1/2] Revert "nvmet-tcp: Don't free SQ on authentication success" alistair23
2026-04-17  0:48 ` [PATCH 2/2] nvmet-tcp: Don't clear tls_key when freeing sq alistair23
2026-04-17  5:35   ` Hannes Reinecke
2026-04-17 16:58   ` Chris Leech
2026-04-17  5:35 ` [PATCH 1/2] Revert "nvmet-tcp: Don't free SQ on authentication success" Hannes Reinecke
2026-04-17 16:57 ` Chris Leech
2026-04-20 16:23 ` Keith Busch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeZTEAYE6uryLbuf@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=alistair.francis@wdc.com \
    --cc=alistair23@gmail.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=mlombard@arkamax.eu \
    --cc=sagi@grimberg.me \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=yi.zhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.