All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Rick P Edgecombe <rick.p.edgecombe@intel.com>
Cc: Ackerley Tng <ackerleytng@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	 "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	 "linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: selftests: Include linux version of mman.h
Date: Mon, 27 Apr 2026 16:57:28 -0700	[thread overview]
Message-ID: <ae_36Po7n6JDrkxU@google.com> (raw)
In-Reply-To: <34e88a990e667ee402238a13a63b224dea1bcfa0.camel@intel.com>

On Mon, Apr 27, 2026, Rick P Edgecombe wrote:
> On Mon, 2026-04-27 at 16:39 -0700, Sean Christopherson wrote:
> > However, for mman.h, we actually need both.  linux/mman.h provides the bleeding
> > header flags and definitions, but sys/mman.h proves the syscall wrappers that
> > selftests expect/use.  The below builds because sys/mman.h is getting included
> > elsewhere, more than likely by tools/testing/selftests/kvm/include/test_util.h.
> > 
> > Rather than updating individual tests on an ad hoc basis, what if we try our
> > best to handle this once?
> 
> Sounds reasonable to me. But I couldn't find the base commit that let me apply
> this in order to test it.

LOL, it's probably a good thing you can't, because it'd be a bit embarrassing on
my end.  The shortlogs I have locally are a mix of "tmp" and NSFW exclamations of
frustration :-)

> Do you want me to turn it into a patch?

I can just send it as a patch?  It'll probably be more work for you get it applied.

  reply	other threads:[~2026-04-27 23:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 20:43 [PATCH] KVM: selftests: Include linux version of mman.h Rick Edgecombe
2026-04-27 23:39 ` Sean Christopherson
2026-04-27 23:49   ` Edgecombe, Rick P
2026-04-27 23:57     ` Sean Christopherson [this message]
2026-04-27 23:59       ` Edgecombe, Rick P
2026-04-28 23:55 ` Ackerley Tng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae_36Po7n6JDrkxU@google.com \
    --to=seanjc@google.com \
    --cc=ackerleytng@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.