Re: [PATCH] drm/i915: remove unused DPLL_TEST register definitions

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Apr 20, 2026 at 11:46:47PM +0300, Luca Coelho wrote:
> Remove the old DPLL_TEST register definitions from i915_reg.h.
> 
> They are no longer used anywhere in the driver.

Reading register definitions is easier than reading the spec.
So unless they are incorrect I don't want to remove the
register definitions for anything.

> 
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 5d99b99b0c57..68bd0b3a6f83 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -509,18 +509,6 @@
>  #define   IVB_SPR_STRETCH_MAX_X2	REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 2)
>  #define   IVB_SPR_STRETCH_MAX_X1	REG_FIELD_PREP(IVB_SPR_STRETCH_MAX_MASK, 3)
>  
> -#define DPLL_TEST	_MMIO(0x606c)
> -#define   DPLLB_TEST_SDVO_DIV_1		(0 << 22)
> -#define   DPLLB_TEST_SDVO_DIV_2		(1 << 22)
> -#define   DPLLB_TEST_SDVO_DIV_4		(2 << 22)
> -#define   DPLLB_TEST_SDVO_DIV_MASK	(3 << 22)
> -#define   DPLLB_TEST_N_BYPASS		(1 << 19)
> -#define   DPLLB_TEST_M_BYPASS		(1 << 18)
> -#define   DPLLB_INPUT_BUFFER_ENABLE	(1 << 16)
> -#define   DPLLA_TEST_N_BYPASS		(1 << 3)
> -#define   DPLLA_TEST_M_BYPASS		(1 << 2)
> -#define   DPLLA_INPUT_BUFFER_ENABLE	(1 << 0)
> -
>  #define D_STATE		_MMIO(0x6104)
>  #define  DSTATE_GFX_RESET_I830			(1 << 6)
>  #define  DSTATE_PLL_D3_OFF			(1 << 3)
> -- 
> 2.53.0

-- 
Ville Syrjälä
Intel