From: Magnus Damm <magnus.damm@gmail.com>
To: linux-scsi@vger.kernel.org
Subject: BusLogic: MAX_DMA_ADDRESS
Date: Wed, 17 Nov 2004 16:26:26 +0100 [thread overview]
Message-ID: <aec7e5c30411170726bcd6824@mail.gmail.com> (raw)
Hello,
The constant MAX_DMA_ADDRESS is used at two places in the code, and I
believe that ">=" comparsion should be used instead of ">". Compare
with other drivers that use that constant.
Also, comments say something about hardware problems related to 16MiB
but the code checks against MAX_DMA_ADDRESS that could be set to
something else than 16MiB on non-i386 archs.
I think the most portable solution would be to remove the entire
"high_memory vs MAX_DMA_ADDRESS"-check and always enable
bounce-buffers for ISA-devices and BT-445S.
Who is running a 2.6-kernel on a machine with 16MiB or less RAM and
SCSI these days anyway...?
/ magnus
reply other threads:[~2004-11-17 15:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30411170726bcd6824@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.