From: Raag Jadav <raag.jadav@intel.com>
To: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
rodrigo.vivi@intel.com, andrealmeid@igalia.com,
christian.koenig@amd.com, airlied@gmail.com,
simona.vetter@ffwll.ch, mripard@kernel.org,
anshuman.gupta@intel.com, badal.nilawar@intel.com,
riana.tauro@intel.com, karthik.poosa@intel.com,
sk.anirban@intel.com
Subject: Re: [PATCH v4 2/4] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method
Date: Tue, 21 Apr 2026 10:19:50 +0200 [thread overview]
Message-ID: <aeczJmU41-uTgT13@black.igk.intel.com> (raw)
In-Reply-To: <20260413133013.560239-8-mallesh.koujalagi@intel.com>
On Mon, Apr 13, 2026 at 07:00:16PM +0530, Mallesh Koujalagi wrote:
> Introduce DRM_WEDGE_RECOVERY_COLD_RESET (BIT(4)) recovery method to handle
> scenarios requiring device power cycle.
>
> This method addresses cases where other recovery mechanisms
> (driver reload, PCIe reset, etc.) are insufficient to restore device
> functionality. When set, it indicates to userspace that only device power
> cycle can recover the device from its current error state. The cold reset
> method serves as a last resort when all other recovery options have been
> exhausted.
>
> v3:
> - Update any scenario that requires cold-reset. (Riana)
>
> v4:
> - Rename cold reset to power cyclce. (Raag)
>
> Signed-off-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
> drivers/gpu/drm/drm_drv.c | 2 ++
> include/drm/drm_device.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 985c283cf59f..8c0236e2e6a6 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -535,6 +535,8 @@ static const char *drm_get_wedge_recovery(unsigned int opt)
> return "bus-reset";
> case DRM_WEDGE_RECOVERY_VENDOR:
> return "vendor-specific";
> + case DRM_WEDGE_RECOVERY_COLD_RESET:
> + return "cold-reset";
> default:
> return NULL;
> }
> diff --git a/include/drm/drm_device.h b/include/drm/drm_device.h
> index bc78fb77cc27..3e386eb42023 100644
> --- a/include/drm/drm_device.h
> +++ b/include/drm/drm_device.h
> @@ -37,6 +37,7 @@ struct pci_controller;
> #define DRM_WEDGE_RECOVERY_REBIND BIT(1) /* unbind + bind driver */
> #define DRM_WEDGE_RECOVERY_BUS_RESET BIT(2) /* unbind + reset bus device + bind */
> #define DRM_WEDGE_RECOVERY_VENDOR BIT(3) /* vendor specific recovery method */
> +#define DRM_WEDGE_RECOVERY_COLD_RESET BIT(4) /* full device cold reset */
Make the comment consistent with consumer expectations in next patch.
Raag
next prev parent reply other threads:[~2026-04-21 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-13 13:30 [PATCH v4 0/4] Introduce cold reset recovery method Mallesh Koujalagi
2026-04-13 13:30 ` [PATCH v4 1/4] Introduce Xe Uncorrectable Error Handling Mallesh Koujalagi
2026-04-13 13:30 ` [PATCH v4 2/4] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method Mallesh Koujalagi
2026-04-21 8:19 ` Raag Jadav [this message]
2026-04-13 13:30 ` [PATCH v4 3/4] drm/doc: Document " Mallesh Koujalagi
2026-04-21 8:30 ` Raag Jadav
2026-05-12 8:29 ` Mallesh, Koujalagi
2026-04-13 13:30 ` [PATCH v4 4/4] drm/xe: Handle PUNIT errors by requesting cold-reset recovery Mallesh Koujalagi
2026-04-21 9:11 ` Raag Jadav
2026-04-13 17:43 ` ✗ CI.checkpatch: warning for Introduce cold reset recovery method (rev3) Patchwork
2026-04-13 17:44 ` ✓ CI.KUnit: success " Patchwork
2026-04-13 18:45 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-13 21:22 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeczJmU41-uTgT13@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=airlied@gmail.com \
--cc=andrealmeid@igalia.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
--cc=mallesh.koujalagi@intel.com \
--cc=mripard@kernel.org \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=sk.anirban@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.