From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v2 4/7] drm/i915/guc: Make submission
 tasklet hardirq safe
Date: Tue, 8 May 2018 18:43:18 +0100
Message-ID: <aed08778-ed77-65fc-d3b5-b5f301ac033c@linux.intel.com>
References: <20180507135731.10587-1-chris@chris-wilson.co.uk>
 <20180507135731.10587-4-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 78C1D6EB0A
 for <intel-gfx@lists.freedesktop.org>; Tue,  8 May 2018 17:43:20 +0000 (UTC)
In-Reply-To: <20180507135731.10587-4-chris@chris-wilson.co.uk>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDA3LzA1LzIwMTggMTQ6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBQcmVwYXJlIHRvIGFs
bG93IHRoZSBHdUMgc3VibWlzc2lvbiB0byBiZSBydW4gZnJvbSB1bmRlcm5lYXRoIGEKPiBoYXJk
aXJxIHRpbWVyIGNvbnRleHQgKGFuZCBub3QganVzdCB0aGUgY3VycmVudCBzb2Z0aXJxIGNvbnRl
eHQpIGFzIGlzCj4gcmVxdWlyZWQgZm9yIGZhc3QgcHJlZW1wdGlvbiByZXNldHMgYW5kIGNvbnRl
eHQgc3dpdGNoZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJp
cy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNf
c3VibWlzc2lvbi5jIHwgMzQgKysrKysrKysrKysrKysrLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdl
ZCwgMjUgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24uYyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMKPiBpbmRleCA2MjgyOGUzOWVlMjYuLjJmZWI2
NTA5Njk2NiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfc3Vi
bWlzc2lvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Np
b24uYwo+IEBAIC02NjksNyArNjY5LDcgQEAgc3RhdGljIGlubGluZSBpbnQgcG9ydF9wcmlvKGNv
bnN0IHN0cnVjdCBleGVjbGlzdF9wb3J0ICpwb3J0KQo+ICAgCXJldHVybiBycV9wcmlvKHBvcnRf
cmVxdWVzdChwb3J0KSk7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgZ3VjX2RlcXVldWUoc3Ry
dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICtzdGF0aWMgYm9vbCBfX2d1Y19kZXF1ZXVl
KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxf
ZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cyA9ICZlbmdpbmUtPmV4ZWNsaXN0czsK
PiAgIAlzdHJ1Y3QgZXhlY2xpc3RfcG9ydCAqcG9ydCA9IGV4ZWNsaXN0cy0+cG9ydDsKPiBAQCAt
Njc5LDcgKzY3OSw4IEBAIHN0YXRpYyB2b2lkIGd1Y19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdp
bmVfY3MgKmVuZ2luZSkKPiAgIAlib29sIHN1Ym1pdCA9IGZhbHNlOwo+ICAgCXN0cnVjdCByYl9u
b2RlICpyYjsKPiAgIAo+IC0Jc3Bpbl9sb2NrX2lycSgmZW5naW5lLT50aW1lbGluZS5sb2NrKTsK
PiArCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmVuZ2luZS0+dGltZWxpbmUubG9jayk7Cj4gKwo+ICAg
CXJiID0gZXhlY2xpc3RzLT5maXJzdDsKPiAgIAlHRU1fQlVHX09OKHJiX2ZpcnN0KCZleGVjbGlz
dHMtPnF1ZXVlKSAhPSByYik7Cj4gICAKPiBAQCAtNjk0LDEzICs2OTUsMTMgQEAgc3RhdGljIHZv
aWQgZ3VjX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCQkJCQkJ
ICAgICBFWEVDTElTVFNfQUNUSVZFX1BSRUVNUFQpOwo+ICAgCQkJCXF1ZXVlX3dvcmsoZW5naW5l
LT5pOTE1LT5ndWMucHJlZW1wdF93cSwKPiAgIAkJCQkJICAgJnByZWVtcHRfd29yay0+d29yayk7
Cj4gLQkJCQlnb3RvIHVubG9jazsKPiArCQkJCXJldHVybiBmYWxzZTsKPiAgIAkJCX0KPiAgIAkJ
fQo+ICAgCj4gICAJCXBvcnQrKzsKPiAgIAkJaWYgKHBvcnRfaXNzZXQocG9ydCkpCj4gLQkJCWdv
dG8gdW5sb2NrOwo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gICAJfQo+ICAgCUdFTV9CVUdfT04ocG9y
dF9pc3NldChwb3J0KSk7Cj4gICAKPiBAQCAtNzM4LDE5ICs3MzksMzQgQEAgc3RhdGljIHZvaWQg
Z3VjX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgZG9uZToKPiAg
IAlleGVjbGlzdHMtPnF1ZXVlX3ByaW9yaXR5ID0gcmIgPyB0b19wcmlvbGlzdChyYiktPnByaW9y
aXR5IDogSU5UX01JTjsKPiAgIAlleGVjbGlzdHMtPmZpcnN0ID0gcmI7Cj4gLQlpZiAoc3VibWl0
KSB7Cj4gKwlpZiAoc3VibWl0KQo+ICAgCQlwb3J0X2Fzc2lnbihwb3J0LCBsYXN0KTsKPiArCWlm
IChsYXN0KQo+ICAgCQlleGVjbGlzdHNfdXNlcl9iZWdpbihleGVjbGlzdHMsIGV4ZWNsaXN0cy0+
cG9ydCk7Cj4gLQkJZ3VjX3N1Ym1pdChlbmdpbmUpOwo+IC0JfQo+ICAgCj4gICAJLyogV2UgbXVz
dCBhbHdheXMga2VlcCB0aGUgYmVhc3QgZmVkIGlmIHdlIGhhdmUgd29yayBwaWxlZCB1cCAqLwo+
ICAgCUdFTV9CVUdfT04ocG9ydF9pc3NldChleGVjbGlzdHMtPnBvcnQpICYmCj4gICAJCSAgICFl
eGVjbGlzdHNfaXNfYWN0aXZlKGV4ZWNsaXN0cywgRVhFQ0xJU1RTX0FDVElWRV9VU0VSKSk7Cj4g
ICAJR0VNX0JVR19PTihleGVjbGlzdHMtPmZpcnN0ICYmICFwb3J0X2lzc2V0KGV4ZWNsaXN0cy0+
cG9ydCkpOwo+ICAgCj4gLXVubG9jazoKPiAtCXNwaW5fdW5sb2NrX2lycSgmZW5naW5lLT50aW1l
bGluZS5sb2NrKTsKPiArCXJldHVybiBzdWJtaXQ7Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGd1
Y19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiArewo+ICsJdW5zaWdu
ZWQgbG9uZyBmbGFnczsKPiArCWJvb2wgc3VibWl0Owo+ICsKPiArCWxvY2FsX2lycV9zYXZlKGZs
YWdzKTsKPiArCj4gKwlzcGluX2xvY2soJmVuZ2luZS0+dGltZWxpbmUubG9jayk7Cj4gKwlzdWJt
aXQgPSBfX2d1Y19kZXF1ZXVlKGVuZ2luZSk7Cj4gKwlzcGluX3VubG9jaygmZW5naW5lLT50aW1l
bGluZS5sb2NrKTsKPiArCj4gKwlpZiAoc3VibWl0KQo+ICsJCWd1Y19zdWJtaXQoZW5naW5lKTsK
PiArCj4gKwlsb2NhbF9pcnFfcmVzdG9yZShmbGFncyk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2
b2lkIGd1Y19zdWJtaXNzaW9uX3Rhc2tsZXQodW5zaWduZWQgbG9uZyBkYXRhKQo+IAoKUmV2aWV3
ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+CgpSZWdhcmRz
LAoKVHZydGtvCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK