Re: [PATCH 0/3] migration: switch remaining positioned I/O to _all helpers

[Peter Xu <peterx@redhat.com>]

On Tue, Apr 21, 2026 at 04:13:14AM +0800, Junjie Cao wrote:
> Follow-up to the pread/pwrite_all API series [1].
> 
> qemu_put_buffer_at(), qemu_get_buffer_at(), and file_write_ramblock_iov()
> all use single-shot positioned I/O without retry.  They share the same
> pattern as the bug fixed in multifd_file_recv_data() where a short
> transfer would be mishandled.
> 
> Convert them to the _all helpers and clean up a pre-existing
> const-correctness issue in qemu_get_buffer_at() along the way.
> 
> After this series no positioned I/O call site in migration/ uses raw
> single-shot channel operations.
> 
> Depends-on: <20260413214549.926435-1-junjie.cao@intel.com>
> ("io/channel: complete pread/pwrite_all API and fix
> multifd_file_recv_data")
> 
> [1] https://lore.kernel.org/qemu-devel/20260413214549.926435-1-junjie.cao@intel.com/
> 
> Junjie Cao (3):
>   migration/qemu-file: switch buffer_at functions to positioned I/O _all
>     helpers
>   migration/file: switch file_write_ramblock_iov to pwritev_all
>   migration/qemu-file: drop incorrect const from qemu_get_buffer_at buf

Thanks a lot, Junjie.  All look sane.

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu