From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2 net-next 1/2] net: bgmac: improve handling PHY
Date: Tue, 5 Oct 2021 19:03:10 -0700 [thread overview]
Message-ID: <aeea5997-4e98-2ebe-9675-7ab883f4b422@gmail.com> (raw)
In-Reply-To: <20211005182138.01b1bf98@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 10/5/2021 6:21 PM, Jakub Kicinski wrote:
> On Sat, 2 Oct 2021 19:58:11 +0200 Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> 1. Use info from DT if available
>>
>> It allows describing for example a fixed link. It's more accurate than
>> just guessing there may be one (depending on a chipset).
>>
>> 2. Verify PHY ID before trying to connect PHY
>>
>> PHY addr 0x1e (30) is special in Broadcom routers and means a switch
>> connected as MDIO devices instead of a real PHY. Don't try connecting to
>> it.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> V2: Promote it out of RFC and send together with MDIO patch per
>> Florian's request.
>
> Florian, ack?
>
Roger roger, thanks for the ping.
--
Florian
next prev parent reply other threads:[~2021-10-06 2:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 17:58 [PATCH V2 net-next 1/2] net: bgmac: improve handling PHY Rafał Miłecki
2021-10-02 17:58 ` [PATCH V2 net-next 2/2] net: bgmac: support MDIO described in DT Rafał Miłecki
2021-10-06 1:49 ` Florian Fainelli
2021-10-06 1:21 ` [PATCH V2 net-next 1/2] net: bgmac: improve handling PHY Jakub Kicinski
2021-10-06 2:03 ` Florian Fainelli [this message]
2021-10-06 1:49 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeea5997-4e98-2ebe-9675-7ab883f4b422@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.