From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 1/6] drm/i915: Limit C-states when waiting for the active request Date: Mon, 6 Aug 2018 10:34:54 +0100 Message-ID: References: <20180806083017.32215-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E971F6E24E for ; Mon, 6 Aug 2018 09:34:59 +0000 (UTC) In-Reply-To: <20180806083017.32215-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Eero Tamminen List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA2LzA4LzIwMTggMDk6MzAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJZiB3ZSBhcmUgd2Fp dGluZyBmb3IgdGhlIGN1cnJlbnRseSBleGVjdXRpbmcgcmVxdWVzdCwgd2UgaGF2ZSBhIGdvb2QK PiBpZGVhIHRoYXQgaXQgd2lsbCBiZSBjb21wbGV0ZWQgaW4gdGhlIHZlcnkgbmVhciBmdXR1cmUg YW5kIHNvIHdhbnQgdG8KPiBjYXAgdGhlIENQVV9ETUFfTEFURU5DWSB0byBlbnN1cmUgdGhhdCB3 ZSB3YWtlIHVwIHRoZSBjbGllbnQgcXVpY2tseS4KCkkgY2Fubm90IHNoYWtlIHRoZSBvcGluaW9u IHRoYXQgd2Ugc2hvdWxkbid0IGJlIGRvaW5nIHRoaXMuIEZvciBpbnN0YW5jZSAKd2hhdCBpZiB0 aGUgY2xpZW50IGhhcyBiZWVuIHJlLW5pY2VkIChkb3duKSwgb3IgaXQgaGFzIHJlLW5pY2VkIGl0 c2VsZj8gCk9idmlvdXNseSB3cm9uZyB0byBhcHBseSB0aGlzIGZvciB0aG9zZS4KCk9yIHdoZW4g eW91IHNheSB3ZSBoYXZlIGEgZ29vZCBpZGVhIHNvbWV0aGluZyB3aWxsIGJlIGNvbXBsZXRlZCBp biB0aGUgCnZlcnkgbmVhciBmdXR1cmUuIFNheSB0aGVyZSBpcyBhIDYwZnBzIHdvcmtsb2FkIHdo aWNoIGlzIHNlbmRpbmcgNW1zIApiYXRjaGVzIGFuZCB3YWl0cyBvbiB0aGVtLiBUaGF0IHdvdWxk IGJlIDMwJSBvZiB0aW1lIHNwZW50IG91dHNpZGUgb2YgCmxvdyBDIHN0YXRlcyBmb3IgYSB3b3Jr bG9hZCB3aGljaCBkb2Vzbid0IG5lZWQgaXQuCgpBbHNvIGhhdmluZyByZWFkIHdoYXQgdGhlIE9w ZW5DTCBkb2VzLCB3aGVyZSB0aGV5IHdhbnQgdG8gYXBwbHkgCmRpZmZlcmVudCB3YWl0IG9wdGlt aXNhdGlvbnMgZm9yIGRpZmZlcmVudCBjYWxsLXNpdGVzLCB0aGUgaWRlYSB0aGF0IHdlIApzaG91 bGQgaW5zdGVhZCBiZSBpbnRyb2R1Y2luZyBhIGxvdy1sYXRlbmN5IGZsYWcgdG8gd2FpdCBpb2N0 bCBzb3VuZHMgCm1vcmUgYXBwcm9wcmlhdGUuCgo+IAo+IHYyOiBOb3QgYWxsb3dlZCB0byBibG9j ayBpbiBrbWFsbG9jIGFmdGVyIHNldHRpbmcgVEFTS19JTlRFUlJVUFRJQkxFLgo+IHYzOiBBdm9p ZCB0aGUgYmxvY2tpbmcgbm90aWZpZXIgYXMgd2VsbCBmb3IgVEFTS19JTlRFUlJVUFRJQkxFCj4g djQ6IEJlYXV0aWZpY2F0aW9uPwo+IHY1OiBBbmQgaWdub3JlIHRoZSBwcmVlbXB0aWJpbGl0eSBv ZiBxdWV1ZV93b3JrIGJlZm9yZSBzY2hlZHVsZS4KPiB2NjogVXNlIGhpZ2hwcmkgd3EgdG8ga2Vl cCBvdXIgcG1fcW9zIHdpbmRvdyBhcyBzbWFsbCBhcyBwb3NzaWJsZS4KPiAKPiBUZXN0Y2FzZTog aWd0L2dlbV9zeW5jL3N0b3JlLWRlZmF1bHQKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51 cnN1bGluQGxpbnV4LmludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFo dGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBFZXJvIFRhbW1pbmVuIDxlZXJvLnQudGFtbWlu ZW5AaW50ZWwuY29tPgo+IENjOiBGcmFuY2lzY28gSmVyZXogPGN1cnJvamVyZXpAcmlzZXVwLm5l dD4KPiBDYzogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4g Q2M6IERtaXRyeSBSb2dvemhraW4gPGRtaXRyeS52LnJvZ296aGtpbkBpbnRlbC5jb20+Cj4gLS0t Cj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYyB8IDU5ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrCj4gICAxIGZpbGUgY2hhbmdlZCwgNTkgaW5zZXJ0aW9ucygrKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVxdWVzdC5jCj4gaW5kZXggNWMyYzkzY2JhYjEyLi42 N2ZkMmVjNzVkNzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1 ZXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+IEBAIC0x MjU4LDYgKzEyNTgsNTggQEAgc3RhdGljIGJvb2wgX19pOTE1X3dhaXRfcmVxdWVzdF9jaGVja19h bmRfcmVzZXQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcmVxdWVzdCkKPiAgIAlyZXR1cm4gdHJ1ZTsK PiAgIH0KPiAgIAo+ICtzdHJ1Y3Qgd2FpdF9kbWFfcW9zIHsKPiArCXN0cnVjdCBwbV9xb3NfcmVx dWVzdCByZXE7Cj4gKwlzdHJ1Y3Qgd29ya19zdHJ1Y3QgYWRkLCBkZWw7Cj4gK307Cj4gKwo+ICtz dGF0aWMgdm9pZCBfX3dhaXRfZG1hX3Fvc19hZGQoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ ICt7Cj4gKwlzdHJ1Y3Qgd2FpdF9kbWFfcW9zICpxb3MgPSBjb250YWluZXJfb2Yod29yaywgdHlw ZW9mKCpxb3MpLCBhZGQpOwo+ICsKPiArCXBtX3Fvc19hZGRfcmVxdWVzdCgmcW9zLT5yZXEsIFBN X1FPU19DUFVfRE1BX0xBVEVOQ1ksIDUwKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgX193YWl0 X2RtYV9xb3NfZGVsKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiArewo+ICsJc3RydWN0IHdh aXRfZG1hX3FvcyAqcW9zID0gY29udGFpbmVyX29mKHdvcmssIHR5cGVvZigqcW9zKSwgZGVsKTsK PiArCj4gKwlpZiAoIWNhbmNlbF93b3JrX3N5bmMoJnFvcy0+YWRkKSkKPiArCQlwbV9xb3NfcmVt b3ZlX3JlcXVlc3QoJnFvcy0+cmVxKTsKPiArCj4gKwlrZnJlZShxb3MpOwo+ICt9Cj4gKwo+ICtz dGF0aWMgc3RydWN0IHdhaXRfZG1hX3FvcyAqd2FpdF9kbWFfcW9zX2FkZCh2b2lkKQo+ICt7Cj4g KwlzdHJ1Y3Qgd2FpdF9kbWFfcW9zICpxb3M7Cj4gKwo+ICsJLyogQ2FsbGVkIHVuZGVyIFRBU0tf SU5URVJSVVBUSUJMRSwgc28gbm90IGFsbG93ZWQgdG8gc2xlZXAvYmxvY2suICovCj4gKwlxb3Mg PSBremFsbG9jKHNpemVvZigqcW9zKSwgR0ZQX05PV0FJVCB8IF9fR0ZQX05PV0FSTik7Cj4gKwlp ZiAoIXFvcykKPiArCQlyZXR1cm4gTlVMTDsKPiArCj4gKwlJTklUX1dPUksoJnFvcy0+YWRkLCBf X3dhaXRfZG1hX3Fvc19hZGQpOwo+ICsJSU5JVF9XT1JLKCZxb3MtPmRlbCwgX193YWl0X2RtYV9x b3NfZGVsKTsKPiArCj4gKwkvKgo+ICsJICogU2NoZWR1bGUgdGhlIGVuYWJsaW5nIHdvcmsgb24g dGhlIGxvY2FsIGNwdSBzbyB0aGF0IGl0IHNob3VsZCBvbmx5Cj4gKwkgKiB0YWtlIGVmZmVjdCBp ZiB3ZSBhY3R1YWxseSBzbGVlcC4gSWYgc2NoZWR1bGUoKSBzaG9ydCBjaXJjdWl0cyBkdWUgdG8K PiArCSAqIG91ciByZXF1ZXN0IGFscmVhZHkgYmVpbmcgY29tcGxldGVkLCB3ZSBzaG91bGQgdGhl biBiZSBhYmxlIHRvIGNhbmNlbAo+ICsJICogdGhlIHdvcmsgYmVmb3JlIGl0IGlzIGV2ZW4gcnVu Lgo+ICsJICovCj4gKwlxdWV1ZV93b3JrX29uKHJhd19zbXBfcHJvY2Vzc29yX2lkKCksIHN5c3Rl bV9oaWdocHJpX3dxLCAmcW9zLT5hZGQpOwo+ICsKPiArCXJldHVybiBxb3M7Cj4gK30KPiArCj4g K3N0YXRpYyB2b2lkIHdhaXRfZG1hX3Fvc19kZWwoc3RydWN0IHdhaXRfZG1hX3FvcyAqcW9zKQo+ ICt7Cj4gKwkvKiBEZWZlciB0byB3b3JrZXIgc28gbm90IGluY3VyIGV4dHJhIGxhdGVuY3kgZm9y IG91ciB3b2tlbiBjbGllbnQuICovCj4gKwlpZiAocW9zKQo+ICsJCXF1ZXVlX3dvcmsoc3lzdGVt X2hpZ2hwcmlfd3EsICZxb3MtPmRlbCk7Cj4gK30KPiArCj4gICAvKioKPiAgICAqIGk5MTVfcmVx dWVzdF93YWl0IC0gd2FpdCB1bnRpbCBleGVjdXRpb24gb2YgcmVxdWVzdCBoYXMgZmluaXNoZWQK PiAgICAqIEBycTogdGhlIHJlcXVlc3QgdG8gd2FpdCB1cG9uCj4gQEAgLTEyODYsNiArMTMzOCw3 IEBAIGxvbmcgaTkxNV9yZXF1ZXN0X3dhaXQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsCj4gICAJ d2FpdF9xdWV1ZV9oZWFkX3QgKmVycnEgPSAmcnEtPmk5MTUtPmdwdV9lcnJvci53YWl0X3F1ZXVl Owo+ICAgCURFRklORV9XQUlUX0ZVTkMocmVzZXQsIGRlZmF1bHRfd2FrZV9mdW5jdGlvbik7Cj4g ICAJREVGSU5FX1dBSVRfRlVOQyhleGVjLCBkZWZhdWx0X3dha2VfZnVuY3Rpb24pOwo+ICsJc3Ry dWN0IHdhaXRfZG1hX3FvcyAqcW9zID0gTlVMTDsKPiAgIAlzdHJ1Y3QgaW50ZWxfd2FpdCB3YWl0 Owo+ICAgCj4gICAJbWlnaHRfc2xlZXAoKTsKPiBAQCAtMTM2Myw2ICsxNDE2LDExIEBAIGxvbmcg aTkxNV9yZXF1ZXN0X3dhaXQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsCj4gICAJCQlicmVhazsK PiAgIAkJfQo+ICAgCj4gKwkJaWYgKCFxb3MgJiYKPiArCQkgICAgaTkxNV9zZXFub19wYXNzZWQo aW50ZWxfZW5naW5lX2dldF9zZXFubyhycS0+ZW5naW5lKSwKPiArCQkJCSAgICAgIHdhaXQuc2Vx bm8gLSAxKSkKCkkgYWxzbyByZWFsaXplZCB0aGF0IHRoaXMgd2lsbCBnZXQgaW5jb3JyZWN0bHkg YXBwbGllZCB3aGVuIHRoZXJlIGlzIApwcmVlbXB0aW9uLiBJZiBhIGxvdy1wcmlvcml0eSByZXF1 ZXN0IGdldHMgcHJlZW1wdGVkIGFmdGVyIHdlIGFwcGxpZWQgCnRoZSBQTSBRb1MgaXQgd2lsbCBw ZXJzaXN0IGZvciBtdWNoIGxvbmdlciB0aGFuIGludGVuZGVkLiAoVW50aWwgdGhlIApoaWdoLXBy aW8gcmVxdWVzdCBjb21wbGV0ZXMgYW5kIHRoZW4gbG93LXByaW8gb25lLikgQW5kIHRoZSBleHBs aWNpdCAKbG93LWxhdGVuY3kgd2FpdCBmbGFnIHdvdWxkIGhhdmUgdGhlIHNhbWUgcHJvYmxlbS4g V2UgY291bGQgcGVyaGFwcyBnbyAKd2l0aCByZW1vdmluZyB0aGUgUE0gUW9TIHJlcXVlc3QgaWYg cHJlZW1wdGVkLiBJdCBzaG91bGQgbm90IGJlIGZyZXF1ZW50IAplbm91Z2ggdG8gY2F1c2UgaXNz dWUgd2l0aCB0b28gbXVjaCB0cmFmZmljIG9uIHRoZSBBUEkuIEJ1dAoKQW5vdGhlciBzaWRlIG5v dGUgLSBxdWljayBncmVwIHNob3dzIHRoZXJlIGFyZSBhIGZldyBvdGhlciAic2Vxbm8gLSAxIiAK Y2FsbHNpdGVzIHNvIHBlcmhhcHMgd2Ugc2hvdWxkIGFkZCBhIGhlbHBlciBmb3IgdGhpcyB3aXRo IGEgbW9yZSAKc2VsZi1leHBsYW5hdG9yeSBsaWtlIF9faTkxNV9zZXFub19pc19leGVjdXRpbmco ZW5naW5lLCBzZXFubykgb3Igc29tZXRoaW5nPwoKPiArCQkJcW9zID0gd2FpdF9kbWFfcW9zX2Fk ZCgpOwo+ICsKPiAgIAkJdGltZW91dCA9IGlvX3NjaGVkdWxlX3RpbWVvdXQodGltZW91dCk7Cj4g ICAKPiAgIAkJaWYgKGludGVsX3dhaXRfY29tcGxldGUoJndhaXQpICYmCj4gQEAgLTE0MTIsNiAr MTQ3MCw3IEBAIGxvbmcgaTkxNV9yZXF1ZXN0X3dhaXQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEs Cj4gICAJaWYgKGZsYWdzICYgSTkxNV9XQUlUX0xPQ0tFRCkKPiAgIAkJcmVtb3ZlX3dhaXRfcXVl dWUoZXJycSwgJnJlc2V0KTsKPiAgIAlyZW1vdmVfd2FpdF9xdWV1ZSgmcnEtPmV4ZWN1dGUsICZl eGVjKTsKPiArCXdhaXRfZG1hX3Fvc19kZWwocW9zKTsKPiAgIAl0cmFjZV9pOTE1X3JlcXVlc3Rf d2FpdF9lbmQocnEpOwo+ICAgCj4gICAJcmV0dXJuIHRpbWVvdXQ7Cj4KUmVnYXJkcywKClR2cnRr bwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK