From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 4/5] drm/i915: refactor ring error state capture to use arrays Date: Sun, 30 Oct 2011 19:32:38 +0000 Message-ID: References: <1320001932-1846-1-git-send-email-daniel.vetter@ffwll.ch> <1320001932-1846-4-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 359589EB3E for ; Sun, 30 Oct 2011 12:32:44 -0700 (PDT) In-Reply-To: <1320001932-1846-4-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Sun, 30 Oct 2011 20:12:11 +0100, Daniel Vetter wrote: > The code already got unwindy and we want to dump more per-ring > registers. So this patch is to cook the spaghetti then? Not sure if unwindy conjures the right imagery, I still think you mean unwieldly. ;) > Only functional change is that we now also capture the video > ring registers on ilk. > > v2: fixup a refactor fumble spotted by Chris Wilson. > > Signed-off-by: Daniel Vetter Reviewed-by: Chris Wilson -- Chris Wilson, Intel Open Source Technology Centre