From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org,
Eugeni Dodonov <eugeni.dodonov@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there
Date: Mon, 31 Oct 2011 19:45:09 +0000 [thread overview]
Message-ID: <aefc95$22g03j@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1318857150-2117-2-git-send-email-eugeni.dodonov@intel.com>
On Mon, 17 Oct 2011 11:12:29 -0200, Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:
> This allows to avoid talking to a non-existent bus repeatedly until we
> finally timeout. The non-existent bus is signalled by -ENXIO error,
> provided by i2c_algo_bit:bit_doAddress call.
>
> As the advantage of such change, all the other routines which use
> drm_get_edid would benefit for this timeout.
>
> This change should fix
> https://bugs.freedesktop.org/show_bug.cgi?id=41059 and improve overall
> edid detection timing by 10-30% in most cases, and by a much larger margin
> in case of phantom outputs.
>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Looks like we have reached the conclusion that this simple patch is the
least likely to cause problems and easiest to fix if it does. :)
Reviewed-by: Chris Wilson <chris@hchris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-10-31 19:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 13:12 [PATCH] Improvements in edid detection timings (final) Eugeni Dodonov
2011-10-17 13:12 ` [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there Eugeni Dodonov
2011-10-17 20:41 ` Keith Packard
2011-10-17 21:07 ` Eugeni Dodonov
2011-10-17 22:41 ` Keith Packard
2011-10-18 0:06 ` Eugeni Dodonov
2011-10-18 10:02 ` [Intel-gfx] " Dave Airlie
2011-10-18 13:14 ` Jean Delvare
2011-10-18 13:37 ` Eugeni Dodonov
2011-10-20 12:33 ` Jean Delvare
2011-10-20 12:40 ` Jean Delvare
2011-10-20 13:13 ` Jean Delvare
2011-10-20 13:18 ` Michael Büsch
2011-10-24 14:40 ` Eugeni Dodonov
2011-10-25 13:03 ` [PATCH] Give up on edid retries when i2c bus is not responding Eugeni Dodonov
2011-10-26 17:06 ` Eugeni Dodonov
2011-10-26 17:18 ` Chris Wilson
2011-10-26 17:35 ` Eugeni Dodonov
2011-10-30 15:53 ` [Intel-gfx] [PATCH 1/2] Give up on edid retries when i2c tells us that bus is not there Jean Delvare
2011-10-18 14:01 ` Alex Deucher
2011-11-01 0:31 ` [PATCH] edid candidate for -next Eugeni Dodonov
2011-11-01 0:31 ` [PATCH] Give up on edid retries when i2c bus is not responding Eugeni Dodonov
2011-10-31 19:45 ` Chris Wilson [this message]
2011-10-17 13:12 ` [PATCH 2/2] Check if the bus is valid prior to discovering edid Eugeni Dodonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$22g03j@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.