From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] uxa/glamor: Enable the rest glamor rendering functions. Date: Tue, 13 Dec 2011 18:20:01 +0000 Message-ID: References: <1323786701-29955-1-git-send-email-zhigang.gong@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B5C09E755 for ; Tue, 13 Dec 2011 10:34:29 -0800 (PST) In-Reply-To: <1323786701-29955-1-git-send-email-zhigang.gong@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: zhigang.gong@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 13 Dec 2011 22:31:41 +0800, zhigang.gong@linux.intel.com wrote: > From: Zhigang Gong > > This commit enable all the rest glamor rendering functions. > Tested with latest glamor master branch, can pass rendercheck. > > One thing need to be pointed out is the picture's handling. > Pictures support many different color formats, but glamor's > texture only support a few color formats. And the most common > scenario is that we create a pixmap with a color depth and > then attach it to a picture which has a specific color format > with the same color depth. But there is no way to change a > texture's internal format after the texture was allocated. > If you do that, the OpenGL will allocate a new texture. And > then the glamor side and UXA side will be inconsitence. So > for all the picture related operations, we can't fallback to > UXA path directly, even it is rather a strainth forward > operation. So for the get_image, Addtraps.., we have to add > wrappers function for them to jump into glamor firstly. Can we create multiple textures referencing the same bo but with different formats? Or are we going to run afoul of the coherency model with GL? -Chris -- Chris Wilson, Intel Open Source Technology Centre