From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] uxa/glamor: Enable the rest glamor rendering functions. Date: Tue, 13 Dec 2011 18:44:47 +0000 Message-ID: References: <1323786701-29955-1-git-send-email-zhigang.gong@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id B67069F4D4 for ; Tue, 13 Dec 2011 11:12:21 -0800 (PST) In-Reply-To: <1323786701-29955-1-git-send-email-zhigang.gong@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: zhigang.gong@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 13 Dec 2011 22:31:41 +0800, zhigang.gong@linux.intel.com wrote: > From: Zhigang Gong > > This commit enable all the rest glamor rendering functions. > Tested with latest glamor master branch, can pass rendercheck. Hmm, it exposes an issue with keeping a bo cache independent of mesa and trying to feed it our own handles: Region for name 6 already exists but is not compatible The w/a for this would be: diff --git a/src/intel_glamor.c b/src/intel_glamor.c index 0cf8ed7..2757fd6 100644 --- a/src/intel_glamor.c +++ b/src/intel_glamor.c @@ -91,6 +91,7 @@ intel_glamor_create_textured_pixmap(PixmapPtr pixmap) priv = intel_get_pixmap_private(pixmap); if (glamor_egl_create_textured_pixmap(pixmap, priv->bo->handle, priv->stride)) { + drm_intel_bo_disable_reuse(priv->bo); priv->pinned = 1; return TRUE; } else but that gives up all pretense of maintaining a bo cache. -Chris -- Chris Wilson, Intel Open Source Technology Centre