From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 1/5] drm/vgem: virtual GEM provider
Date: Wed, 08 Feb 2012 23:28:42 +0000
Message-ID: <aefc95$34igt1@orsmga001.jf.intel.com>
References: <1328743171-13750-1-git-send-email-ben@bwidawsk.net>
	<1328743171-13750-2-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id D361C9E76E
	for <dri-devel@lists.freedesktop.org>;
	Wed,  8 Feb 2012 15:28:48 -0800 (PST)
In-Reply-To: <1328743171-13750-2-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Thu,  9 Feb 2012 00:19:27 +0100, Ben Widawsky <ben@bwidawsk.net> wrote:
> From: Adam Jackson <ajax@redhat.com>
> +static void vgem_gem_free_object(struct drm_gem_object *obj)
> +{
> +	if (obj->map_list.map)
> +		drm_gem_free_mmap_offset(obj);
> +
> +	drm_gem_object_release(obj);
> +}

drm_gem_free_mmap_offset() should be pushed down into
drm_gem_object_release(). Out of the 6 distinct users of
drm_gem_object_release(), 3 call drm_gem_free_mmap_offset() just prior
and gma500 forgets to.

I do accept that it is a separate patch though ;-)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre