From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jesse Barnes <jbarnes@virtuousgeek.org>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/9] drm/i915: split out Ironlake pipe bpp picking code
Date: Fri, 24 Jun 2011 10:58:57 +0100 [thread overview]
Message-ID: <aefc95$iat4h@orsmga001.jf.intel.com> (raw)
In-Reply-To: <1305136090-5858-7-git-send-email-jbarnes@virtuousgeek.org>
On Wed, 11 May 2011 10:48:07 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> +static bool intel_choose_pipe_bpp_dither(struct drm_crtc *crtc,
> + unsigned int *pipe_bpp)
> +{
> + struct drm_device *dev = crtc->dev;
> + struct drm_i915_private *dev_priv = dev->dev_private;
> + struct drm_encoder *encoder;
> + struct drm_connector *connector;
> + unsigned int display_bpc = UINT_MAX, fb_bpc, bpc;
> +
> + fb_bpc = crtc->fb->depth / 3;
Very misleading. Set but never used.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-06-24 9:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 17:48 Deep color support and bug fixes Jesse Barnes
2011-05-11 17:48 ` [PATCH 1/9] drm: add bit depth parsing Jesse Barnes
2011-05-11 17:48 ` [PATCH 2/9] drm: parse color format support for digital displays Jesse Barnes
2011-05-11 17:48 ` [PATCH 3/9] drm/i915: don't set SDVO color range on ILK+ Jesse Barnes
2011-06-24 5:50 ` Keith Packard
2011-05-11 17:48 ` [PATCH 4/9] drm/i915: don't set transcoder bpc on CougarPoint Jesse Barnes
2011-06-23 21:16 ` Keith Packard
2011-05-11 17:48 ` [PATCH 5/9] drm/i915: set bpc for DP transcoder Jesse Barnes
2011-05-11 17:48 ` [PATCH 6/9] drm/i915: split out Ironlake pipe bpp picking code Jesse Barnes
2011-06-24 9:58 ` Chris Wilson [this message]
2011-05-11 17:48 ` [PATCH 7/9] drm/i915: split out plane update code Jesse Barnes
2011-05-11 17:48 ` [PATCH 8/9] drm/i915: use pipe bpp in DP link bandwidth calculations Jesse Barnes
2011-05-11 17:48 ` [PATCH 9/9] drm/i915: use pipe bpp when setting HDMI bpc Jesse Barnes
2011-06-24 9:32 ` Deep color support and bug fixes Chris Wilson
2011-06-24 10:24 ` Chris Wilson
2011-06-24 12:46 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$iat4h@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.