From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Skip GPU wait for scanout pin while wedged Date: Wed, 20 Jul 2011 01:03:17 +0100 Message-ID: References: <1311118003-3443-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 752A89E9BF for ; Tue, 19 Jul 2011 17:03:20 -0700 (PDT) In-Reply-To: <1311118003-3443-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 19 Jul 2011 16:26:43 -0700, Keith Packard wrote: > Failing to pin a scanout buffer will most likely lead to a black > screen, so if the GPU is wedged, then just let the pin happen and hope > that things work out OK. This doesn't prevent us returning an error should the wait-rendering abort due to a GPU hang occurring in the middle of the wait. i915_gem_object_pin_to_display_plane is used for more than just the scanout, cursors and overlay are also included, otherwise we could just ignore any errors. So, /* Update the display engine regardless of any GPU hangs */ if (ret == -ERESTARTSYS) return ret; -Chris -- Chris Wilson, Intel Open Source Technology Centre