From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Skip GPU wait for scanout pin while wedged Date: Wed, 20 Jul 2011 23:28:27 +0100 Message-ID: References: <1311121733-15526-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id C0A209EFEF for ; Wed, 20 Jul 2011 15:28:30 -0700 (PDT) In-Reply-To: <1311121733-15526-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Keith Packard , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, 19 Jul 2011 17:28:53 -0700, Keith Packard wrote: > Failing to pin a scanout buffer will most likely lead to a black > screen, so if the GPU is wedged, then just let the pin happen and hope > that things work out OK. > > v2: Just ignore any error from i915_gem_object_wait_rendering, as > suggested by Chris Wilson > > Signed-off-by: Keith Packard I couldn't find a way to make this any simpler, or spot why it couldn't possible work, so Reviewed-by: Chris Wilson For the sake of our sanity, we should document which paths we think can safely ignore GPU hangs. Can we detect lockups in any other functions? Would any of the test signals help us diagnose which link in the chain failed? -Chris -- Chris Wilson, Intel Open Source Technology Centre