All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>,
	Damien Le Moal <dlemoal@kernel.org>,
	Hans Holmberg <hans.holmberg@wdc.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: expose the number of free zones in sysfs
Date: Wed, 22 Apr 2026 12:29:14 +0200	[thread overview]
Message-ID: <aeii-qIyPawexQci@ryzen> (raw)
In-Reply-To: <20260422060322.GC5391@lst.de>

On Wed, Apr 22, 2026 at 08:03:22AM +0200, Christoph Hellwig wrote:
> On Mon, Apr 20, 2026 at 03:50:13PM +0200, Niklas Cassel wrote:
> > The number of free zones is currently available in /proc/<pid>/mountstats
> > (which contains stats for all mounted zoned XFS filesystems), under
> > "free zones:".
> > 
> > Add a sysfs attribute /sys/fs/xfs/<dev>/zoned/nr_free_zones for the same.
> > This makes it trivial for monitoring software to read the value, for a
> > specific filesystem, without any complex parsing.
> 
> The usual way to expose stats in xfs is through the stats sysfs file.
> Which requires some parsing, but the usual monitoring tools already
> have this.

So we have the following options:
1) /sys/fs/xfs/<dev>/zoned/
2) /sys/fs/xfs/<dev>/stats/stats
3) /sys/kernel/debug/xfs/<dev>/


You say that the usual way to expose stats is through 2)
but e.g. nr_open_zones is exposed via 1), introduced in commit
62c89988dc19 ("xfs: expose the number of open zones in sysfs")
(You are the author of that commit btw :))


In my mind, nr_open_zones and nr_free_zones is very similar,
so I though it was most logical to have them in the same place.


That said, if you prefer 2) or 3) over 1) for exposing nr_free_zones,
please tell me which you prefer, and I can send a V2 with that.


Kind regards,
Niklas

  reply	other threads:[~2026-04-22 10:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 13:50 [PATCH 0/2] xfs: add additional zoned sysfs attributes Niklas Cassel
2026-04-20 13:50 ` [PATCH 1/2] xfs: expose the number of free zones in sysfs Niklas Cassel
2026-04-20 15:39   ` Damien Le Moal
2026-04-22  6:03   ` Christoph Hellwig
2026-04-22 10:29     ` Niklas Cassel [this message]
2026-04-23  5:11       ` Christoph Hellwig
2026-04-23  9:14         ` Niklas Cassel
2026-04-23 12:17           ` Hans Holmberg
2026-04-20 13:50 ` [PATCH 2/2] xfs: expose the current zonegc required status " Niklas Cassel
2026-04-20 15:47   ` Damien Le Moal
2026-04-20 16:09     ` Niklas Cassel
2026-04-22  6:04   ` Christoph Hellwig
2026-04-22 10:31     ` Niklas Cassel
2026-04-23  5:12       ` Christoph Hellwig
2026-04-22  6:02 ` [PATCH 0/2] xfs: add additional zoned sysfs attributes Christoph Hellwig
2026-04-22  7:17   ` Carlos Maiolino
2026-04-22  9:53   ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeii-qIyPawexQci@ryzen \
    --to=cassel@kernel.org \
    --cc=cem@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=hans.holmberg@wdc.com \
    --cc=hch@lst.de \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.