Re: [PATCH v3 3/7] vpci: Use pervcpu ranges for BAR mapping

["Roger Pau Monné" <roger.pau@citrix.com>]

On Wed, Apr 22, 2026 at 02:04:59PM +0200, Jan Beulich wrote:
> On 22.04.2026 13:00, Roger Pau Monné wrote:
> > On Thu, Apr 09, 2026 at 02:01:33PM +0000, Mykyta Poturai wrote:
> >> @@ -412,14 +414,14 @@ int vpci_modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only)
> >>          unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) +
> >>                                       vmsix_table_size(pdev->vpci, i) - 1);
> >>  
> >> -        for ( j = 0; j < ARRAY_SIZE(header->bars); j++ )
> >> +        for ( j = 0; j < ARRAY_SIZE(current->vpci.mem); j++ )
> > 
> > You make a non-trivial use of current in vpci_modify_bars(), maybe you
> > should consider introducing a local variable for it:
> > 
> > struct *vcpu curr = current;
> 
> Without any intention to negate this, ...
> 
> > current expands to a call to get_cpu_info(9, which is better to avoid
> > doing repeatedly, specially in the context above which is used as a
> > loop upper bound.
> 
> ... I'd like to point out that "current" isn't evaluated when used by
> ARRAY_SIZE() (resolving to two uses of sizeof()).

Oh indeed, this is just for getting the type.

Thanks, Roger.