From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: andersson@kernel.org, fabien.dessenne@st.com,
ludovic.barre@st.com, loic.pallardy@st.com,
arnaud.pouliquen@st.com, linux-kernel@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2] remoteproc: dead code cleanup in Kconfig for STM32_RPROC
Date: Wed, 22 Apr 2026 08:24:48 -0600 [thread overview]
Message-ID: <aejaMFEc6WRJY_hg@p14s> (raw)
In-Reply-To: <20260417221337.286313-1-julianbraha@gmail.com>
On Fri, Apr 17, 2026 at 11:13:37PM +0100, Julian Braha wrote:
> There is already an 'if REMOTEPROC' condition wrapping this config option,
> making the 'depends on REMOTEPROC' statement a duplicate dependency
> (dead code).
>
> I propose leaving the outer 'if REMOTEPROC...endif' and removing the
> individual 'depends on REMOTEPROC' statement.
>
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> v2: fix typo in commit message
> Link to v1: https://lore.kernel.org/all/20260330224545.29769-1-julianbraha@gmail.com/
> ---
> drivers/remoteproc/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
I have picked-up this patch. It will show up in rproc-next when 7.1-rc1 is
released next week.
Thanks,
Mathieu
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index ee54436fea5a..c78e431b7b2d 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
> config STM32_RPROC
> tristate "STM32 remoteproc support"
> depends on ARCH_STM32 || COMPILE_TEST
> - depends on REMOTEPROC
> select MAILBOX
> help
> Say y here to support STM32 MCU processors via the
> --
> 2.53.0
>
prev parent reply other threads:[~2026-04-22 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 22:13 [PATCH v2] remoteproc: dead code cleanup in Kconfig for STM32_RPROC Julian Braha
2026-04-22 14:24 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aejaMFEc6WRJY_hg@p14s \
--to=mathieu.poirier@linaro.org \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@st.com \
--cc=fabien.dessenne@st.com \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ludovic.barre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.